You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/05/03 06:41:20 UTC

[GitHub] [submarine] Kenchu123 opened a new pull request #577: SUBMARINE-814. Install local pytorchjob chart via helm golang API

Kenchu123 opened a new pull request #577:
URL: https://github.com/apache/submarine/pull/577


   
   ### What is this PR for?
   
   pytorch chart: 
   
   https://github.com/apache/submarine/tree/master/helm-charts/submarine/charts/pytorchjob
   
   Helm golang API: 
   
   https://github.com/apache/submarine/blob/master/submarine-cloud-v2/pkg/helm/helm.go
   
   ### What type of PR is it?
   [Feature]
   
   ### Todos
   
   ### What is the Jira issue?
   
   https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-814
   
   ### How should this be tested?
   
   https://www.travis-ci.com/github/Kenchu123/submarine/builds/224734346
   
   ### Screenshots (if appropriate)
   
   By operator:
   
   helm
   
   ![helm](https://i.imgur.com/bJOPwms.png)
   
   pods
   
   ![](https://i.imgur.com/DUMgcqk.png)
   
   deployments
   
   ![](https://i.imgur.com/RvcYglm.png)
   
   services
   
   ![](https://i.imgur.com/CjRZRVF.png)
   
   replicaset
   
   ![](https://i.imgur.com/rFRqWbC.png)
   
   ### Questions:
   
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kevin85421 commented on pull request #577: SUBMARINE-814. Install local pytorchjob chart via helm golang API

Posted by GitBox <gi...@apache.org>.
kevin85421 commented on pull request #577:
URL: https://github.com/apache/submarine/pull/577#issuecomment-835818901


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kevin85421 merged pull request #577: SUBMARINE-814. Install local pytorchjob chart via helm golang API

Posted by GitBox <gi...@apache.org>.
kevin85421 merged pull request #577:
URL: https://github.com/apache/submarine/pull/577


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org