You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2019/05/14 02:59:19 UTC

[GitHub] [wicket] andruhon edited a comment on issue #361: WICKET-6666 initial checkin of new ModalDialog

andruhon edited a comment on issue #361: WICKET-6666 initial checkin of new ModalDialog
URL: https://github.com/apache/wicket/pull/361#issuecomment-492059377
 
 
   Just tested the modal in Chrome, FF, Edge and IE11 all good. Looks a bit dodgy in IE11.
   
   > I doubt that is possible. Each dialog works in fundamentally different ways, so a base class makes little sense. The only reason why a separate class exists is to make migration easier, eventually ModalWindow will be removed.
   
   I agree, old one has quite inconsistent naming it does irrelevant show/close, instead of antonyms pairs such as show/hide or open/close any many other strange things. Maybe only a new one can extend such an abstract class.
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services