[GitHub] mbaijal opened a new pull request #9128: Fix example/reinforcement-learning/dqn

[GitBox <gi...@apache.org>]

mbaijal opened a new pull request #9128: Fix example/reinforcement-learning/dqn
URL: https://github.com/apache/incubator-mxnet/pull/9128
 
 
   ## Description ##
     - This example was not compatible with python3. I made necessary changes. 
     - I also updated the README with the Pre-reqs I needed to make the example work on the CONDA AMI (mxnet_p36/mxnet_p27 envs)
   
   ## Checklist ##
   ### Essentials ###
   - [x] Passed code style checking (`make lint`)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] Some changes to atari_game.py to make it compatible with both python2 and python3.
   - [x] Some changes to base.py to make it compatible with python2 and python3.
   - [x] Updated README
   
   ## Comments ##
     - I have tested on the Deep Learning AMI with Conda (Ubuntu) (ami-405ade3a)
     - I fixed it such that it works with both python 3.x and python 2.x
     - I have not verified the accuracy or validity of results.
     - I have not tested on Mac OS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services