[GitHub] rabbah commented on a change in pull request #3980: Log activation retrieval from activation store for block invocations

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #3980: Log activation retrieval from activation store for block invocations
URL: https://github.com/apache/incubator-openwhisk/pull/3980#discussion_r212067343
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
 ##########
 @@ -613,7 +613,13 @@ protected[actions] trait PrimitiveActions {
     if (!result.isCompleted && retries < maxRetries) {
       val schedule = actorSystem.scheduler.scheduleOnce(wait(retries)) {
         activationStore.get(ActivationId(docid.asString), context).onComplete {
-          case Success(activation)             => result.trySuccess(Right(activation))
+          case Success(activation) =>
 
 Review comment:
   do you just want to count the number of times the result is retrieved from the DB directly vs active ack, or the total number of times this poller is sheduled?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services