You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/03 23:42:46 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #9465:
[WiP] imorting validators module from superset-ui
rusackas opened a new pull request #9465: [WiP] imorting validators module from superset-ui
URL: https://github.com/apache/incubator-superset/pull/9465
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [x] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9465: Importing
validators module from superset-ui
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9465: Importing validators module from superset-ui
URL: https://github.com/apache/incubator-superset/pull/9465#issuecomment-613227331
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9465?src=pr&el=h1) Report
> Merging [#9465](https://codecov.io/gh/apache/incubator-superset/pull/9465?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f29d0fd9f2f93cf27e55475c61130518060d17fc&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9465?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9465 +/- ##
==========================================
- Coverage 58.78% 58.77% -0.02%
==========================================
Files 390 389 -1
Lines 12386 12370 -16
Branches 3073 3066 -7
==========================================
- Hits 7281 7270 -11
+ Misses 4921 4917 -4
+ Partials 184 183 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9465?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.36% <0.00%> (ø)` | |
| [...nd/src/explore/components/controls/TextControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC5qc3g=) | `13.79% <0.00%> (ø)` | |
| [...rset-frontend/src/explore/controlPanels/DeckArc.js](https://codecov.io/gh/apache/incubator-superset/pull/9465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrQXJjLmpz) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/DeckGeojson.js](https://codecov.io/gh/apache/incubator-superset/pull/9465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrR2VvanNvbi5qcw==) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/DeckMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...-frontend/src/explore/controlPanels/DeckScatter.js](https://codecov.io/gh/apache/incubator-superset/pull/9465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrU2NhdHRlci5qcw==) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/EventFlow.js](https://codecov.io/gh/apache/incubator-superset/pull/9465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9FdmVudEZsb3cuanM=) | `0.00% <ø> (ø)` | |
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <ø> (ø)` | |
| [...t-frontend/src/explore/controlPanels/Partition.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9QYXJ0aXRpb24uanN4) | `0.00% <ø> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/9465/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9465?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9465?src=pr&el=footer). Last update [f29d0fd...81a07a1](https://codecov.io/gh/apache/incubator-superset/pull/9465?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on issue #9465: Importing
validators module from superset-ui
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #9465: Importing validators module from superset-ui
URL: https://github.com/apache/incubator-superset/pull/9465#issuecomment-613229998
> > import { legacyValidateInteger, legacyValidateNumber, validateNonEmpty } from '@superset-ui/validator';
> > There is a non-legacy `validateInteger` and `validateNumber` which has the logical behavior, but will break superset because it seems to expect the wrong output from the legacy functions at the moment.
>
> You should use `legacyValidateInteger` and `legacyValidateNumber`.
>
> [apache-superset/superset-ui#322](https://github.com/apache-superset/superset-ui/pull/322)
>
> I'll move these note into the package `README`
Ahhh, thanks. Didn't catch the intent. I'll see about unifying those, as I don't love the idea of moving forward with "legacy" things in a refactor project, but it seems CI is green, yay!
If you don't mind giving this a review, that'd be wonderful.
Thanks,
-e-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on issue #9465: Importing
validators module from superset-ui
Posted by GitBox <gi...@apache.org>.
kristw commented on issue #9465: Importing validators module from superset-ui
URL: https://github.com/apache/incubator-superset/pull/9465#issuecomment-613559048
> Ahhh, thanks. Didn't catch the intent. I'll see about unifying those, as I don't love the idea of moving forward with "legacy" things in a refactor project, but it seems CI is green, yay!
Agree. I tried to think of clean way to do the migration while discourage people from using the illogical method in more places. We should sweep and get rid of them at some point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on issue #9465: Importing
validators module from superset-ui
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #9465: Importing validators module from superset-ui
URL: https://github.com/apache/incubator-superset/pull/9465#issuecomment-613157769
@kristw I'm having a hard time figuring out why I can't get cypress to live through a run... does anything jump out at you here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #9465: Importing
validators module from superset-ui
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #9465: Importing validators module from superset-ui
URL: https://github.com/apache/incubator-superset/pull/9465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on issue #9465: Importing
validators module from superset-ui
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #9465: Importing validators module from superset-ui
URL: https://github.com/apache/incubator-superset/pull/9465#issuecomment-613559601
> Sorry. I notice two `package-lock.json`. Please remove the one in root.
Good eyes! Removed, and re-Travis-ing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on issue #9465: Importing
validators module from superset-ui
Posted by GitBox <gi...@apache.org>.
kristw commented on issue #9465: Importing validators module from superset-ui
URL: https://github.com/apache/incubator-superset/pull/9465#issuecomment-613158846
> import { legacyValidateInteger, legacyValidateNumber, validateNonEmpty } from '@superset-ui/validator';
> There is a non-legacy `validateInteger` and `validateNumber` which has the logical behavior, but will break superset because it seems to expect the wrong output from the legacy functions at the moment.
You should use `legacyValidateInteger` and `legacyValidateNumber`.
https://github.com/apache-superset/superset-ui/pull/322
I'll move these note into the package `README`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org