You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/21 18:35:38 UTC
[GitHub] [beam] Abacn opened a new pull request, #24756: Support SqlTypes Date in AvroUtils
Abacn opened a new pull request, #24756:
URL: https://github.com/apache/beam/pull/24756
Fixes #23299
Re-introduce part of #23969 (one direction SqlTypes Date to Avro Date) which was later reverted due to breaking change to Beam SQL. The breaking change of #23969 was the introduce of bi-direction Avro TimestampMicros and SqlTypes DateTime support which is not included in this PR.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24756: Support SqlTypes Date in AvroUtils
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24756:
URL: https://github.com/apache/beam/pull/24756#issuecomment-1367517309
There is an ongoing migration of avro-related stuff from core to extension (#24292). The first step (#24293) copied AvroUtils into an extension project not including this PR. Mark here and need to synchronize newly added code changes of core avro to avro extension before #24748 resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24756: Support SqlTypes Date in AvroUtils
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24756:
URL: https://github.com/apache/beam/pull/24756#issuecomment-1362139538
[Java_Examples_Dataflow_Java17](https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java17_Commit/4923/) and [Java_GCP_IO_Direct](https://ci-beam.apache.org/job/beam_PreCommit_Java_GCP_IO_Direct_Commit/1170/) actually passed but did not show status on GitHub
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24756: Support SqlTypes Date in AvroUtils
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24756:
URL: https://github.com/apache/beam/pull/24756#issuecomment-1361855865
This PR suffices to fix the requested use case of #23299 (beam:logical_type:date:v1 which is SqlTypes.DATE) , though SqlTypes.TIMESTAMP remains unsupported to AvroUtils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24756: Support SqlTypes Date in AvroUtils
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24756:
URL: https://github.com/apache/beam/pull/24756#issuecomment-1362139701
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24756: Support SqlTypes Date in AvroUtils
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24756:
URL: https://github.com/apache/beam/pull/24756#issuecomment-1361999735
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @lukecwik for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24756: Support SqlTypes Date in AvroUtils
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24756:
URL: https://github.com/apache/beam/pull/24756#issuecomment-1362137137
R: @apilloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #24756: Support SqlTypes Date in AvroUtils
Posted by GitBox <gi...@apache.org>.
Abacn merged PR #24756:
URL: https://github.com/apache/beam/pull/24756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org