[GitHub] [guacamole-client] elijahnicpon commented on a diff in pull request #746: GUACAMOLE-1320: Provide chunked file upload mechanism

[GitBox <gi...@apache.org>]

elijahnicpon commented on code in PR #746:
URL: https://github.com/apache/guacamole-client/pull/746#discussion_r930368096


##########
guacamole/src/main/java/org/apache/guacamole/tunnel/InputStreamInterceptingFilter.java:
##########
@@ -112,9 +112,8 @@ private void readNextBlob(InterceptedStream<InputStream> stream) {
             // End stream if no more data
             if (length == -1) {
 
-                // Close stream, send end if the stream is still valid
-                if (closeInterceptedStream(stream))
-                    sendEnd(stream.getIndex());
+                // Close stream
+                closeInterceptedStream(stream);

Review Comment:
   The end instruction closes the writer, so without deleting that line, each subsequent chunk would just rewrite the previous. The stream is now closed when the upload is complete by ManagedFileUpload's stream state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org