[GitHub] [cloudstack] shwstppr commented on pull request #4666: Fix bug in creating shared network

[GitBox <gi...@apache.org>]

shwstppr commented on pull request #4666:
URL: https://github.com/apache/cloudstack/pull/4666#issuecomment-801003782


   @ravening any update on this?
   I was able to not see mentioned issue with this,
   ```
   diff --git a/ui/src/views/network/CreateSharedNetworkForm.vue b/ui/src/views/network/CreateSharedNetworkForm.vue
   index e91a5631c4..eaaa38c083 100644
   --- a/ui/src/views/network/CreateSharedNetworkForm.vue
   +++ b/ui/src/views/network/CreateSharedNetworkForm.vue
   @@ -567,7 +567,7 @@ export default {
              var networks = json.listphysicalnetworksresponse.physicalnetwork
              if (this.arrayHasItems(networks)) {
                for (const i in networks) {
   -              this.addPhysicalNetworkForGuestTrafficType(networks[i], i * 1 === networks.length - 1)
   +              this.addPhysicalNetworkForGuestTrafficType(networks[i])
                }
              } else {
                this.formPhysicalNetworkLoading = false
   @@ -576,7 +576,7 @@ export default {
            })
          }
        },
   -    addPhysicalNetworkForGuestTrafficType (physicalNetwork, isLastNetwork) {
   +    addPhysicalNetworkForGuestTrafficType (physicalNetwork) {
          const params = {}
          params.physicalnetworkid = physicalNetwork.id
          api('listTrafficTypes', params).then(json => {
   @@ -592,7 +592,7 @@ export default {
              this.formPhysicalNetworkLoading = false
            }
          }).finally(() => {
   -        if (isLastNetwork) {
   +        if (this.formPhysicalNetworks.length > 0 && this.isObjectEmpty(this.formSelectedPhysicalNetwork)) {
              this.form.setFieldsValue({
                physicalnetworkid: 0
              })
   @@ -736,6 +736,7 @@ export default {
                message: this.$t('message.request.failed'),
                description: this.$t('message.error.add.guest.network')
              })
   +          return
            }
            this.actionLoading = true
            var params = {
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org