You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-commits@hadoop.apache.org by to...@apache.org on 2011/03/07 04:10:20 UTC
svn commit: r1078656 - in /hadoop/mapreduce/trunk: CHANGES.txt
src/java/org/apache/hadoop/mapred/TaskTracker.java
src/test/mapred/org/apache/hadoop/mapred/TestTaskTrackerLocalization.java
Author: todd
Date: Mon Mar 7 03:10:20 2011
New Revision: 1078656
URL: http://svn.apache.org/viewvc?rev=1078656&view=rev
Log:
MAPREDUCE-2272. Job ACL file should not be executable. Contributed by Harsh J Chouraria
Modified:
hadoop/mapreduce/trunk/CHANGES.txt
hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/TaskTracker.java
hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/TestTaskTrackerLocalization.java
Modified: hadoop/mapreduce/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/mapreduce/trunk/CHANGES.txt?rev=1078656&r1=1078655&r2=1078656&view=diff
==============================================================================
--- hadoop/mapreduce/trunk/CHANGES.txt (original)
+++ hadoop/mapreduce/trunk/CHANGES.txt Mon Mar 7 03:10:20 2011
@@ -607,6 +607,9 @@ Release 0.22.0 - Unreleased
MAPREDUCE-2054. Hierarchical queue implementation broke dynamic queue
addition in Dynamic Scheduler. (Thomas Sandholm via tomwhite)
+ MAPREDUCE-2272. Job ACL file should not be executable
+ (Harsh J Chouraria via todd)
+
Release 0.21.1 - Unreleased
NEW FEATURES
Modified: hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/TaskTracker.java
URL: http://svn.apache.org/viewvc/hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/TaskTracker.java?rev=1078656&r1=1078655&r2=1078656&view=diff
==============================================================================
--- hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/TaskTracker.java (original)
+++ hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/TaskTracker.java Mon Mar 7 03:10:20 2011
@@ -59,7 +59,6 @@ import org.apache.hadoop.classification.
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.DF;
import org.apache.hadoop.fs.CommonConfigurationKeys;
-import org.apache.hadoop.fs.FSDataInputStream;
import org.apache.hadoop.fs.FileStatus;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.FileUtil;
@@ -1159,7 +1158,7 @@ public class TaskTracker
FileOutputStream out;
try {
- out = SecureIOUtils.createForWrite(aclFile, 0700);
+ out = SecureIOUtils.createForWrite(aclFile, 0600);
} catch (SecureIOUtils.AlreadyExistsException aee) {
LOG.warn("Job ACL file already exists at " + aclFile, aee);
return;
Modified: hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/TestTaskTrackerLocalization.java
URL: http://svn.apache.org/viewvc/hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/TestTaskTrackerLocalization.java?rev=1078656&r1=1078655&r2=1078656&view=diff
==============================================================================
--- hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/TestTaskTrackerLocalization.java (original)
+++ hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/TestTaskTrackerLocalization.java Mon Mar 7 03:10:20 2011
@@ -576,7 +576,7 @@ public class TestTaskTrackerLocalization
// With default task controller, the job-acls.xml file is owned by TT and
// permissions are 700
- checkFilePermissions(jobACLsFile.getAbsolutePath(), "-rwx------",
+ checkFilePermissions(jobACLsFile.getAbsolutePath(), "-rw-------",
taskTrackerUGI.getShortUserName(), taskTrackerUGI.getGroupNames()[0]);
validateJobACLsFileContent();