You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/10 13:46:04 UTC
[GitHub] [shardingsphere] terrymanu opened a new pull request #10030: Revise GovernanceAuthorityContext to reuse AuthorityProvideAlgorithm
terrymanu opened a new pull request #10030:
URL: https://github.com/apache/shardingsphere/pull/10030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #10030: Revise GovernanceAuthorityContext to reuse AuthorityProvideAlgorithm
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #10030:
URL: https://github.com/apache/shardingsphere/pull/10030#discussion_r611049011
##########
File path: shardingsphere-features/shardingsphere-authority/shardingsphere-authority-common/src/main/java/org/apache/shardingsphere/authority/rule/AuthorityRule.java
##########
@@ -32,14 +33,17 @@
/**
* Authority rule.
*/
+@Getter
public final class AuthorityRule implements GlobalRule {
-
+
Review comment:
emtpy line with 4 white space or that's the front of static qualifier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #10030: Revise GovernanceAuthorityContext to reuse AuthorityProvideAlgorithm
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #10030:
URL: https://github.com/apache/shardingsphere/pull/10030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org