You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/05 12:15:31 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #25549: Show dataset-triggered next run details
bbovenzi opened a new pull request, #25549:
URL: https://github.com/apache/airflow/pull/25549
The "Next Run" for a dataset-triggered DAG only tells you how many datasets need to update in order to trigger a run. Now, if you click on the next run info, it will open a modal which will call the API and get a full list of the datasets and include a timestamp if that have already been updated.
<img width="440" alt="Screen Shot 2022-08-05 at 8 11 46 AM" src="https://user-images.githubusercontent.com/4600967/183075266-c15c361d-2dad-4700-865a-8a9572bceb7b.png">
<img width="615" alt="Screen Shot 2022-08-05 at 8 11 50 AM" src="https://user-images.githubusercontent.com/4600967/183075267-69b652ab-6b2e-44bd-94e5-fce94a6960bc.png">
<img width="1166" alt="Screen Shot 2022-08-05 at 8 12 33 AM" src="https://user-images.githubusercontent.com/4600967/183075268-40eac498-77d4-446e-a040-0bdc121e10b4.png">
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #25549: Show dataset-triggered next run details
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #25549:
URL: https://github.com/apache/airflow/pull/25549#discussion_r938826289
##########
airflow/www/templates/airflow/dags.html:
##########
@@ -19,6 +19,7 @@
{% extends base_template %}
{% from 'appbuilder/loading_dots.html' import loading_dots %}
+{% from 'appbuilder/dataset_next_run_modal.html' import dataset_next_run_modal %}
Review Comment:
This file should probably be
```suggestion
{% from 'airflow/dataset_next_run_modal.html' import dataset_next_run_modal %}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #25549: Show dataset-triggered next run details
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #25549:
URL: https://github.com/apache/airflow/pull/25549#discussion_r938825509
##########
airflow/www/static/js/openDatasetModal.js:
##########
@@ -0,0 +1,66 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/* global $, isoDateToTimeEl, document */
+
+import { getMetaValue } from './utils';
+
+function openDatasetModal(dagId, summary) {
+ let nextRunUrl = getMetaValue('next_run_datasets_url');
+ $('#datasets_tbody').empty();
+ $('#datasets_error').hide();
+ $('#datasetNextRunModal').modal({});
+ $('#dag_id').text(dagId);
+ $('#next_run_summary').text(summary);
+ $('#datasets-loading-dots').css('display', 'inline-block');
+ if (dagId) {
+ if (nextRunUrl.includes('__DAG_ID__')) {
+ nextRunUrl = nextRunUrl.replace('__DAG_ID__', dagId);
+ }
+ $.get(nextRunUrl)
+ .done(
+ (datasets) => {
+ datasets.forEach((d) => {
+ const row = document.createElement('tr');
+
+ const uriCell = document.createElement('td');
+ const datasetLink = document.createElement('a');
+ datasetLink.href = `/datasets?dataset_id=${d.id}`;
Review Comment:
This won't be the right URL if the Airflow isn't "rooted" at `/` (and this is why we use the uri-in-metavalue trick elsewhere)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #25549: Show dataset-triggered next run details
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #25549:
URL: https://github.com/apache/airflow/pull/25549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org