[jira] Commented: (VELOCITY-554) Velocity sources and javadocs missing in the maven repository

["Adrian Tarau (JIRA)" <de...@velocity.apache.org>]

    [ https://issues.apache.org/jira/browse/VELOCITY-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636062#action_12636062 ] 

Adrian Tarau commented on VELOCITY-554:
---------------------------------------

I've changed download.xml to add support for Maven Ant tasks and I have a few comments:

1. First of all current download process uses only download.jarname & download.jarversion to build the path in a Maven1 repository. It worked because groupId was the same as artifactId, but it is not right. I've changed, every download task needs groupdId, artifactId and version. Also added m1 in the download task names to differentiate them from the M2 download tasks.
2. I had do add additional tasks to download jars from Maven 2 repository. I just copied and modified the http-download(now http-m1-download).
3. Since Ant doesn't have build in something for string manipulation, a hierarchical groupId for M2 must be converted to a path.
       instead of  
               <property name="download.groupId" value="org.apache.maven" /> 
      you must put
               <property name="download.groupId" value="org/apache/maven" />
   If this workaround is fine with you, we can let it like this if not we can use :  http://ant-contrib.sourceforge.net/tasks/tasks/propertyregex.html

Please let me know if the current changes are fine with you.



> Velocity sources and javadocs missing in the maven repository
> -------------------------------------------------------------
>
>                 Key: VELOCITY-554
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-554
>             Project: Velocity
>          Issue Type: New Feature
>          Components: Build
>    Affects Versions: 1.5
>            Reporter: Aliaksandr Radzivanovich
>
> It is really annoying when popular projects like Apache Velocity do not provide their sources and javadocs to the Maven repository.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org