(superset) 04/07: disabling NullPool used for testing

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch sqla-close
in repository https://gitbox.apache.org/repos/asf/superset.git

commit c3cea52026ed038c969f341a6c6d57a681a194bf
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Thu Dec 5 11:07:39 2024 -0800

    disabling NullPool used for testing
---
 superset/config.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/superset/config.py b/superset/config.py
index f9d10aca18..8d2ec7cc83 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -204,9 +204,10 @@ SQLALCHEMY_DATABASE_URI = (
 # `SQLALCHEMY_ENGINE_OPTIONS = {"isolation_level": "READ COMMITTED"}`
 # Also note that we recommend READ COMMITTED for regular operation.
 # Find out more here https://flask-sqlalchemy.palletsprojects.com/en/3.1.x/config/
-from sqlalchemy.pool import NullPool
+# for example, if you don't want to use a connection pool, uncomment those next 2 lines
+# from sqlalchemy.pool import NullPool
+# SQLALCHEMY_ENGINE_OPTIONS = {"poolclass": NullPool}
 
-SQLALCHEMY_ENGINE_OPTIONS = {"poolclass": NullPool}
 
 # In order to hook up a custom password store for all SQLALCHEMY connections
 # implement a function that takes a single argument of type 'sqla.engine.url',