You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/12/08 18:14:09 UTC
Review Request 54539: function execution framework has waited for
results from all members, no need to wait in resultCollector
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54539/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: GEODE-2175
https://issues.apache.org/jira/browse/GEODE-2175
Repository: geode
Description
-------
resultReciever.getPartitionedDataFrom() will wait for all replies from each receipient and process the reply at the endpoint's local cache. The PRFunctionStreamingResultCollector is the reply processor.
Remove the unnecessary wait and change the junit test.
Diffs
-----
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollector.java d4a7008
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java af868e2
Diff: https://reviews.apache.org/r/54539/diff/
Testing
-------
precheckin and some manual tests.
Thanks,
xiaojian zhou
Re: Review Request 54539: function execution framework has waited for
results from all members, no need to wait in resultCollector
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54539/#review158584
-----------------------------------------------------------
Fix it, then Ship it!
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java (line 66)
<https://reviews.apache.org/r/54539/#comment229359>
Remove these unused latches.
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java (line 81)
<https://reviews.apache.org/r/54539/#comment229360>
There's no need to use an atomic reference anymore.
- Dan Smith
On Dec. 8, 2016, 6:14 p.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54539/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 6:14 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-2175
> https://issues.apache.org/jira/browse/GEODE-2175
>
>
> Repository: geode
>
>
> Description
> -------
>
> resultReciever.getPartitionedDataFrom() will wait for all replies from each receipient and process the reply at the endpoint's local cache. The PRFunctionStreamingResultCollector is the reply processor.
>
> Remove the unnecessary wait and change the junit test.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollector.java d4a7008
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java af868e2
>
> Diff: https://reviews.apache.org/r/54539/diff/
>
>
> Testing
> -------
>
> precheckin and some manual tests.
>
>
> Thanks,
>
> xiaojian zhou
>
>