You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/07/26 13:44:00 UTC

[GitHub] [incubator-doris] weizuo93 opened a new pull request #6326: [Enhancement] Optimize judgment logic when producing compaction task for single disk

weizuo93 opened a new pull request #6326:
URL: https://github.com/apache/incubator-doris/pull/6326


   
   ## Proposed changes
   
   When producing compaction task for a particular disk, each tablet on BE will be traversed.  Usually, there are several disks on the BE, so that most of tablets locate on other disks which should be skipped.  To reduce some invalid judgment logic, the first thing we should do is to judge whether the tablet is on the target disk.
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   - [ ] Code refactor (Modify the code structure, format the code, etc...)
   - [x] Optimization. Including functional usability improvements and performance improvements.
   - [ ] Dependency. Such as changes related to third-party components.
   - [ ] Other.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman commented on pull request #6326: [Enhancement] Optimize judgment logic when producing compaction task for single disk

Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6326:
URL: https://github.com/apache/incubator-doris/pull/6326#issuecomment-890441425


   HI @weizuo93 , I am try to solving this issue #6355, and it will cover the optimization your did here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman closed pull request #6326: [Enhancement] Optimize judgment logic when producing compaction task for single disk

Posted by GitBox <gi...@apache.org>.
morningman closed pull request #6326:
URL: https://github.com/apache/incubator-doris/pull/6326


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] weizuo93 commented on pull request #6326: [Enhancement] Optimize judgment logic when producing compaction task for single disk

Posted by GitBox <gi...@apache.org>.
weizuo93 commented on pull request #6326:
URL: https://github.com/apache/incubator-doris/pull/6326#issuecomment-890663554


   > HI @weizuo93 , I am try to solving this issue #6355, and it will cover the optimization your did here.
   
   OK. I'm looking forward to your PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman commented on pull request #6326: [Enhancement] Optimize judgment logic when producing compaction task for single disk

Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6326:
URL: https://github.com/apache/incubator-doris/pull/6326#issuecomment-895803425


    #6365 solve this problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org