You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@logging.apache.org by sd...@apache.org on 2010/02/23 08:32:41 UTC

svn commit: r915225 - in /logging/chainsaw/trunk/src/main: java/org/apache/log4j/chainsaw/ resources/org/apache/log4j/chainsaw/prefs/

Author: sdeboy
Date: Tue Feb 23 07:32:41 2010
New Revision: 915225

URL: http://svn.apache.org/viewvc?rev=915225&view=rev
Log:
Chainsaw updates:
Minor layout changes to give messages more room by default
 - Default timestamp format changed to HH:MM:ss
 - Now using level text instead of icons
 - Modified column widths to be a little narrower

Modified:
    logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanel.java
    logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferenceModel.java
    logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogUI.java
    logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/TableColorizingRenderer.java
    logging/chainsaw/trunk/src/main/resources/org/apache/log4j/chainsaw/prefs/default.properties

Modified: logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanel.java
URL: http://svn.apache.org/viewvc/logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanel.java?rev=915225&r1=915224&r2=915225&view=diff
==============================================================================
--- logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanel.java (original)
+++ logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanel.java Tue Feb 23 07:32:41 2010
@@ -199,8 +199,8 @@
  */
 public class LogPanel extends DockablePanel implements EventBatchListener,
   Profileable {
-  private static final double DEFAULT_DETAIL_SPLIT_LOCATION = .5;
-  private static final double DEFAULT_LOG_TREE_SPLIT_LOCATION = .25;
+  private static final double DEFAULT_DETAIL_SPLIT_LOCATION = 0.56d;
+  private static final double DEFAULT_LOG_TREE_SPLIT_LOCATION = 0.2d;
   private final String identifier;
   private final ChainsawStatusBar statusBar;
   private final JFrame preferencesFrame = new JFrame();
@@ -359,7 +359,7 @@
     ButtonGroup dfBG = new ButtonGroup();
     dfBG.add(isoButton);
     dfBG.add(simpleTimeButton);
-    isoButton.setSelected(true);
+    simpleTimeButton.setSelected(true);
     dateFormatChangePopup.add(isoButton);
     dateFormatChangePopup.add(simpleTimeButton);
 

Modified: logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferenceModel.java
URL: http://svn.apache.org/viewvc/logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferenceModel.java?rev=915225&r1=915224&r2=915225&view=diff
==============================================================================
--- logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferenceModel.java (original)
+++ logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferenceModel.java Tue Feb 23 07:32:41 2010
@@ -36,6 +36,7 @@
 import org.apache.log4j.LogManager;
 import org.apache.log4j.Logger;
 import org.apache.log4j.chainsaw.prefs.SettingsManager;
+import org.apache.log4j.helpers.Constants;
 
 
 /**
@@ -66,7 +67,7 @@
 
   private transient final PropertyChangeSupport propertySupport =
     new PropertyChangeSupport(this);
-  private String dateFormatPattern = ISO8601;
+  private String dateFormatPattern = Constants.SIMPLE_TIME_PATTERN;
   private boolean levelIcons;
   private List allColumns = new ArrayList();
   private List visibleColumns = new ArrayList();
@@ -159,7 +160,7 @@
 
   public final void setDefaultDatePatternFormat() {
 	    String oldVal = this.dateFormatPattern;
-	    this.dateFormatPattern = ISO8601;
+	    this.dateFormatPattern = Constants.SIMPLE_TIME_PATTERN;
 	    propertySupport.firePropertyChange(
 	    	      "dateFormatPattern", oldVal, this.dateFormatPattern);
   }

Modified: logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogUI.java
URL: http://svn.apache.org/viewvc/logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogUI.java?rev=915225&r1=915224&r2=915225&view=diff
==============================================================================
--- logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogUI.java (original)
+++ logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogUI.java Tue Feb 23 07:32:41 2010
@@ -148,7 +148,7 @@
   private static final String MAIN_WINDOW_Y = "main.window.y";
   private static final String MAIN_WINDOW_X = "main.window.x";
   private static ChainsawSplash splash;
-  private static final double DEFAULT_MAIN_RECEIVER_SPLIT_LOCATION = .8d;
+  private static final double DEFAULT_MAIN_RECEIVER_SPLIT_LOCATION = 0.85d;
   private final JFrame preferencesFrame = new JFrame();
   private boolean noReceiversDefined;
   private ReceiversPanel receiversPanel;

Modified: logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/TableColorizingRenderer.java
URL: http://svn.apache.org/viewvc/logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/TableColorizingRenderer.java?rev=915225&r1=915224&r2=915225&view=diff
==============================================================================
--- logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/TableColorizingRenderer.java (original)
+++ logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/TableColorizingRenderer.java Tue Feb 23 07:32:41 2010
@@ -54,13 +54,13 @@
  */
 public class TableColorizingRenderer extends DefaultTableCellRenderer {
   private static final DateFormat DATE_FORMATTER =
-    new SimpleDateFormat(Constants.ISO8601_PATTERN);
+    new SimpleDateFormat(Constants.SIMPLE_TIME_PATTERN);
   private static final Map iconMap =
     LevelIconFactory.getInstance().getLevelToIconMap();
   private Colorizer colorizer;
   private final JLabel idComponent = new JLabel();
   private final JLabel levelComponent = new JLabel();
-  private boolean levelUseIcons = true;
+  private boolean levelUseIcons = false;
   private DateFormat dateFormatInUse = DATE_FORMATTER;
   private int loggerPrecision = 0;
   private boolean toolTipsVisible;

Modified: logging/chainsaw/trunk/src/main/resources/org/apache/log4j/chainsaw/prefs/default.properties
URL: http://svn.apache.org/viewvc/logging/chainsaw/trunk/src/main/resources/org/apache/log4j/chainsaw/prefs/default.properties?rev=915225&r1=915224&r2=915225&view=diff
==============================================================================
--- logging/chainsaw/trunk/src/main/resources/org/apache/log4j/chainsaw/prefs/default.properties (original)
+++ logging/chainsaw/trunk/src/main/resources/org/apache/log4j/chainsaw/prefs/default.properties Tue Feb 23 07:32:41 2010
@@ -10,7 +10,7 @@
 main.window.height=768
 
 table.columns.order=ID,TIMESTAMP,LOG4J.MARKER,LEVEL,LOGGER,MESSAGE,THROWABLE,THREAD,NDC,CLASS,METHOD,FILE,LINE
-table.columns.widths=50,150,150,50,100,300,100,150,150,300,150,100,100
+table.columns.widths=50,80,95,50,100,300,100,150,150,300,150,100,100
 
 SavedConfigs.Size=0
 DateFormat.1=HH:mm:ss
@@ -19,8 +19,8 @@
 
 
 # These are the default LogPanel settings
-dateFormatPattern=ISO8601
-levelIcons=true
+dateFormatPattern=HH:mm:ss
+levelIcons=false
 loggerPrecision=
 toolTips=false
 scrollToBottom=true