You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/07/24 14:24:07 UTC
[GitHub] [sling-org-apache-sling-javax-activation] kwin commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460084565
##########
File path: pom.xml
##########
@@ -23,7 +23,7 @@
<parent>
<groupId>org.apache.sling</groupId>
<artifactId>sling</artifactId>
- <version>26</version>
+ <version>39</version>
Review comment:
Please use 'sling-bundle-parent' as artifact id (https://github.com/apache/sling-parent/blob/133c73392e9575cb10ced19ce29e14e7ec61c790/sling-bundle-parent/pom.xml#L29)
##########
File path: pom.xml
##########
@@ -77,6 +100,7 @@
<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.core</artifactId>
+ <version>4.2.0</version>
Review comment:
Please use the managed artifacts from the bundle-parent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org