[GitHub] [spark] dhruve commented on a change in pull request #24498: [SPARK-27605][UI] Add new column "Partition ID" to the tasks table in stages page

[GitBox <gi...@apache.org>]

dhruve commented on a change in pull request #24498: [SPARK-27605][UI] Add new column "Partition ID" to the tasks table in stages page
URL: https://github.com/apache/spark/pull/24498#discussion_r279827518
 
 

 ##########
 File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
 ##########
 @@ -933,18 +942,18 @@ $(document).ready(function () {
                 if (accumulatorTable.length == 0) {
                     $("#accumulator-update-table").hide();
                 } else {
-                    taskTableSelector.column(18).visible(true);
+                    taskTableSelector.column(19).visible(true);
                     $("#accumulator-update-table").show();
                 }
                 // Showing relevant stage data depending on stage type for task table and executor
                 // summary table
-                taskTableSelector.column(19).visible(dataToShow.showInputData);
-                taskTableSelector.column(20).visible(dataToShow.showOutputData);
-                taskTableSelector.column(21).visible(dataToShow.showShuffleWriteData);
+                taskTableSelector.column(20).visible(dataToShow.showInputData);
+                taskTableSelector.column(21).visible(dataToShow.showOutputData);
                 taskTableSelector.column(22).visible(dataToShow.showShuffleWriteData);
-                taskTableSelector.column(23).visible(dataToShow.showShuffleReadData);
-                taskTableSelector.column(24).visible(dataToShow.showBytesSpilledData);
+                taskTableSelector.column(23).visible(dataToShow.showShuffleWriteData);
 
 Review comment:
   Why do we have this repeated twice?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org