You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/10 20:14:56 UTC
svn commit: r1695149 - in
/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile:
LineNumberTable.java LocalVariableTable.java LocalVariableTypeTable.java
ParameterAnnotations.java StackMap.java StackMapTable.java
Author: sebb
Date: Mon Aug 10 18:14:56 2015
New Revision: 1695149
URL: http://svn.apache.org/r1695149
Log:
Inline public setter code which is otherwise unused
Modified:
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumberTable.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTable.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMap.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapTable.java
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumberTable.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumberTable.java?rev=1695149&r1=1695148&r2=1695149&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumberTable.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumberTable.java Mon Aug 10 18:14:56 2015
@@ -37,7 +37,7 @@ public final class LineNumberTable exten
private static final long serialVersionUID = -6967221519632128904L;
- private LineNumber[] line_number_table; // Table of line/numbers pairs
+ private LineNumber[] line_number_table; // Table of line/numbers pairs // TODO could be final (unused setter; copy() would need adjusting)
/*
@@ -58,7 +58,7 @@ public final class LineNumberTable exten
public LineNumberTable(int name_index, int length, LineNumber[] line_number_table,
ConstantPool constant_pool) {
super(Constants.ATTR_LINE_NUMBER_TABLE, name_index, length, constant_pool);
- setLineNumberTable(line_number_table);
+ this.line_number_table = line_number_table;
}
@@ -120,7 +120,7 @@ public final class LineNumberTable exten
/**
* @param line_number_table the line number entries for this table
*/
- public final void setLineNumberTable( LineNumber[] line_number_table ) {
+ public final void setLineNumberTable( LineNumber[] line_number_table ) { // TODO unused
this.line_number_table = line_number_table;
}
@@ -197,6 +197,8 @@ public final class LineNumberTable exten
*/
@Override
public Attribute copy( ConstantPool _constant_pool ) {
+ // TODO could use the lower level constructor and thereby allow
+ // line_number_table to be made final
LineNumberTable c = (LineNumberTable) clone();
c.line_number_table = new LineNumber[line_number_table.length];
for (int i = 0; i < line_number_table.length; i++) {
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTable.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTable.java?rev=1695149&r1=1695148&r2=1695149&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTable.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTable.java Mon Aug 10 18:14:56 2015
@@ -56,7 +56,7 @@ public class LocalVariableTable extends
public LocalVariableTable(int name_index, int length, LocalVariable[] local_variable_table,
ConstantPool constant_pool) {
super(Constants.ATTR_LOCAL_VARIABLE_TABLE, name_index, length, constant_pool);
- setLocalVariableTable(local_variable_table);
+ this.local_variable_table = local_variable_table;
}
@@ -157,7 +157,7 @@ public class LocalVariableTable extends
}
- public final void setLocalVariableTable( LocalVariable[] local_variable_table ) {
+ public final void setLocalVariableTable( LocalVariable[] local_variable_table ) { // TODO unused
this.local_variable_table = local_variable_table;
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java?rev=1695149&r1=1695148&r2=1695149&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java Mon Aug 10 18:14:56 2015
@@ -66,7 +66,7 @@ public class LocalVariableTypeTable exte
public LocalVariableTypeTable(int name_index, int length, LocalVariable[] local_variable_table, ConstantPool constant_pool) {
super(Constants.ATTR_LOCAL_VARIABLE_TYPE_TABLE, name_index, length, constant_pool);
- setLocalVariableTable(local_variable_table);
+ this.local_variable_type_table = local_variable_table;
}
LocalVariableTypeTable(int nameIdx, int len, DataInput input, ConstantPool cpool) throws IOException {
@@ -108,7 +108,7 @@ public class LocalVariableTypeTable exte
return null;
}
- public final void setLocalVariableTable(LocalVariable[] local_variable_table) {
+ public final void setLocalVariableTable(LocalVariable[] local_variable_table) { // TODO unused
this.local_variable_type_table = local_variable_table;
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java?rev=1695149&r1=1695148&r2=1695149&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java Mon Aug 10 18:14:56 2015
@@ -33,7 +33,7 @@ public abstract class ParameterAnnotatio
private static final long serialVersionUID = 5234607357644462705L;
/** Table of parameter annotations */
- private ParameterAnnotationEntry[] parameter_annotation_table;
+ private ParameterAnnotationEntry[] parameter_annotation_table; // TODO could be final (setter unused)
/**
* @param parameter_annotation_type the subclass type of the parameter annotation
@@ -64,7 +64,7 @@ public abstract class ParameterAnnotatio
public ParameterAnnotations(byte parameter_annotation_type, int name_index, int length,
ParameterAnnotationEntry[] parameter_annotation_table, ConstantPool constant_pool) {
super(parameter_annotation_type, name_index, length, constant_pool);
- setParameterAnnotationTable(parameter_annotation_table);
+ this.parameter_annotation_table = parameter_annotation_table;
}
@@ -84,7 +84,7 @@ public abstract class ParameterAnnotatio
/**
* @param parameter_annotation_table the entries to set in this parameter annotation
*/
- public final void setParameterAnnotationTable(ParameterAnnotationEntry[] parameter_annotation_table ) {
+ public final void setParameterAnnotationTable(ParameterAnnotationEntry[] parameter_annotation_table ) { // TODO unused
this.parameter_annotation_table = parameter_annotation_table;
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMap.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMap.java?rev=1695149&r1=1695148&r2=1695149&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMap.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMap.java Mon Aug 10 18:14:56 2015
@@ -41,7 +41,7 @@ import org.apache.commons.bcel6.Constant
public final class StackMap extends Attribute {
private static final long serialVersionUID = -6238662431726968495L;
- private StackMapEntry[] map; // Table of stack map entries
+ private StackMapEntry[] map; // Table of stack map entries // TODO could be final (setter unused)
/*
@@ -52,7 +52,7 @@ public final class StackMap extends Attr
*/
public StackMap(int name_index, int length, StackMapEntry[] map, ConstantPool constant_pool) {
super(Constants.ATTR_STACK_MAP, name_index, length, constant_pool);
- setStackMap(map);
+ this.map = map;
}
@@ -102,7 +102,7 @@ public final class StackMap extends Attr
/**
* @param map Array of stack map entries
*/
- public final void setStackMap( StackMapEntry[] map ) {
+ public final void setStackMap( StackMapEntry[] map ) { // TODO unused
this.map = map;
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapTable.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapTable.java?rev=1695149&r1=1695148&r2=1695149&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapTable.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapTable.java Mon Aug 10 18:14:56 2015
@@ -42,7 +42,7 @@ import org.apache.commons.bcel6.Constant
public final class StackMapTable extends Attribute {
private static final long serialVersionUID = -5802191977296683162L;
- private StackMapTableEntry[] map; // Table of stack map entries
+ private StackMapTableEntry[] map; // Table of stack map entries // TODO could be final (setter unused)
/*
@@ -53,7 +53,7 @@ public final class StackMapTable extends
*/
public StackMapTable(int name_index, int length, StackMapTableEntry[] map, ConstantPool constant_pool) {
super(Constants.ATTR_STACK_MAP_TABLE, name_index, length, constant_pool);
- setStackMapTable(map);
+ this.map = map;
}
@@ -102,7 +102,7 @@ public final class StackMapTable extends
/**
* @param map Array of stack map entries
*/
- public final void setStackMapTable( StackMapTableEntry[] map ) {
+ public final void setStackMapTable( StackMapTableEntry[] map ) { // TODO unused
this.map = map;
}