[jira] [Comment Edited] (DRILL-2884) Have cancel() cause "query canceled" rather than just "ResultSet closed"

["Daniel Barclay (Drill) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613564#comment-14613564 ] 

Daniel Barclay (Drill) edited comment on DRILL-2884 at 7/4/15 4:14 AM:
-----------------------------------------------------------------------

Notes re (current) decision to have successful cancelation cause exception to be thrown from execute...(...) or next(...) (etc.):

[Some Oracle documentation|http://docs.oracle.com/cd/B14117_01/java.101/b10979/tips.htm#BACDAICJ] says:

bq.  "The JDBC standard method Statement.cancel() attempts to cleanly stop the execution of a SQL statement by sending a message to the database. In response, the database stops execution and replies with an error message. "


was (Author: dsbos):
Notes re (current) decision to have successful cancelation cause exception to the thrown from execute...(...) or next(...) (etc.):

[Some Oracle documentation|http://docs.oracle.com/cd/B14117_01/java.101/b10979/tips.htm#BACDAICJ] says:

bq.  "The JDBC standard method Statement.cancel() attempts to cleanly stop the execution of a SQL statement by sending a message to the database. In response, the database stops execution and replies with an error message. "

> Have cancel() cause "query canceled" rather than just "ResultSet closed"
> ------------------------------------------------------------------------
>
>                 Key: DRILL-2884
>                 URL: https://issues.apache.org/jira/browse/DRILL-2884
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Daniel Barclay (Drill)
>            Assignee: Daniel Barclay (Drill)
>             Fix For: 1.0.0
>
>         Attachments: DRILL-2884.1Core.1.patch.txt, DRILL-2884.2Hygiene.1.patch.txt, DRILL-2884.2Hygiene.2.patch.txt
>
>
> After Statement.cancel() is called for a SQL statement's execution, a subsequent call to a method on the ResultSet for that execution yields a "ResultSet already closed" exception.  (This isn't fully implemented yet, but it is for, e.g., next().)
> A call to cancel() should result in an explicit "execution canceled" exception rather than the usual "already closed" exception (so that it doesn't seem like a Drill programming error rather an expected result of canceling).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)