You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2019/06/05 05:59:43 UTC
[incubator-superset] branch master updated: [SQL Lab] CTAS now uses
the right async configuration (#7175)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 1cd0e7f [SQL Lab] CTAS now uses the right async configuration (#7175)
1cd0e7f is described below
commit 1cd0e7f3f44763f844c737aceb1306c38d816ca4
Author: Enrico Berti <he...@enricoberti.com>
AuthorDate: Wed Jun 5 07:59:36 2019 +0200
[SQL Lab] CTAS now uses the right async configuration (#7175)
Closes #6224
---
superset/assets/src/SqlLab/components/SqlEditor.jsx | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/superset/assets/src/SqlLab/components/SqlEditor.jsx b/superset/assets/src/SqlLab/components/SqlEditor.jsx
index 5d58b23..4310768 100644
--- a/superset/assets/src/SqlLab/components/SqlEditor.jsx
+++ b/superset/assets/src/SqlLab/components/SqlEditor.jsx
@@ -242,10 +242,10 @@ class SqlEditor extends React.PureComponent {
}
runQuery() {
if (this.props.database) {
- this.startQuery(this.props.database.allow_run_async);
+ this.startQuery();
}
}
- startQuery(runAsync = false, ctas = false) {
+ startQuery(ctas = false) {
const qe = this.props.queryEditor;
const query = {
dbId: qe.dbId,
@@ -256,7 +256,7 @@ class SqlEditor extends React.PureComponent {
tempTableName: ctas ? this.state.ctas : '',
templateParams: qe.templateParams,
queryLimit: qe.queryLimit || this.props.defaultQueryLimit,
- runAsync,
+ runAsync: this.props.database ? this.props.database.allow_run_async : false,
ctas,
};
this.props.actions.runQuery(query);
@@ -268,7 +268,7 @@ class SqlEditor extends React.PureComponent {
}
}
createTableAs() {
- this.startQuery(true, true);
+ this.startQuery(true);
}
ctasChanged(event) {
this.setState({ ctas: event.target.value });