You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2024/11/21 07:41:21 UTC

[PR] Migrate skin to Doxia 2.x [commons-skin]

slawekjaranowski opened a new pull request, #179:
URL: https://github.com/apache/commons-skin/pull/179

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2490327923

   > @garydgregory @michael-o I have tested with commons parent - one issue what I see is:
   > 
   > ```
   > <title>About ? Apache Commons</title>
   > ```
   > 
   > it is generated question mark
   
   There is an encoding issue some where. ISO-8859-1 somewhere? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #179:
URL: https://github.com/apache/commons-skin/pull/179


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2557569847

   there are tests:
    - https://github.com/apache/commons-parent/pull/561
    - https://github.com/apache/commons-validator/pull/298
    
   @garydgregory site generation looks ok - please verify and we can go forward


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2561977230

   TY @slawekjaranowski 
   I verified by building local changes to this, commons-parent, and validator.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2490356948

   > > @garydgregory @michael-o I have tested with commons parent - one issue what I see is:
   > > ```
   > > <title>About ? Apache Commons</title>
   > > ```
   > > 
   > > 
   > >     
   > >       
   > >     
   > > 
   > >       
   > >     
   > > 
   > >     
   > >   
   > > it is generated question mark
   > 
   > There is an encoding issue some where. ISO-8859-1 somewhere?
   
   There is: https://github.com/apache/commons-parent/blob/master/pom.xml#L278-L284


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2491610800

   @slawekjaranowski 
   
   Thank you so much for the PR! 
   
   I just pushed commit https://github.com/apache/commons-parent/commit/1d943fad67255d84f38244c49034a667c143e116 to commons-parent. 
   
   Would the simplest steps be:
   - Set `commons.encoding` here (commons-skin) to `UTF-8`
   - Release commons-skin 4.3
   - In commons-parent, update from commons-skin 4.2 to 4.3 
   - Release commons-parent 79
   - Update other commons component, including commons-skin to commons-parent 79
   
   ?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2490735093

   > > > @garydgregory @michael-o I have tested with commons parent - one issue what I see is:
   > > > ```
   > > > <title>About ? Apache Commons</title>
   > > > ```
   > > > 
   > > > 
   > > >     
   > > >       
   > > >     
   > > > 
   > > >       
   > > >     
   > > > 
   > > >     
   > > >   
   > > > it is generated question mark
   > > 
   > > 
   > > There is an encoding issue some where. ISO-8859-1 somewhere?
   > 
   > There is: https://github.com/apache/commons-parent/blob/master/pom.xml#L278-L284
   > 
   > after change to `utf-8` it is ok 😄
   
   For me, there is ZERO reason to stick to ISO-8859-X these days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2490297288

   @garydgregory @michael-o 
   I have tested with commons parent - one issue what I see is:
   
   ```
   <title>About ? Apache Commons</title>
   ```
   it is generated question mark


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2491556562

   > > > @garydgregory @michael-o I have tested with commons parent - one issue what I see is:
   > > > ```
   > > > <title>About ? Apache Commons</title>
   > > > ```
   > > > 
   > > > 
   > > >     
   > > >       
   > > >     
   > > > 
   > > >       
   > > >     
   > > > 
   > > >     
   > > >   
   > > > it is generated question mark
   > > 
   > > 
   > > There is an encoding issue some where. ISO-8859-1 somewhere?
   > 
   > There is: https://github.com/apache/commons-parent/blob/master/pom.xml#L278-L284
   > 
   > after change to `utf-8` it is ok 😄
   
   I will make the change in commons parent and create a release candidate. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2557571062

   > @slawekjaranowski
   > 
   > Is this OK to merge and release now that maven-changes-plugin 3.0.0-M1 is available?
   
   yes skin look ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2550522324

   @garydgregory  m-changes-p was released we can process forward
   I will check again parent if site is ok with this and new m-site-p


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2491650152

   @garydgregory 
   - commons-skin 4.3 - will require m-site-p 3.20.0+
   - with m-site-p 3.20.0+ you will need a new version of m-changes-p
    
   so first I would like to finish m-changes-p


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2491719237

   @slawekjaranowski 
   
   OK, TY, I might release a new commons-parent in the meantime, but we'll loop again when m-changes-p is released.
   
   TY again 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Migrate skin to Doxia 2.x [commons-skin]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #179:
URL: https://github.com/apache/commons-skin/pull/179#issuecomment-2557223808

   @slawekjaranowski 
   
   Is this OK to merge and release now that maven-changes-plugin 3.0.0-M1 is available?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org