You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@directory.apache.org by "Lin Chen (JIRA)" <ji...@apache.org> on 2015/04/13 11:38:12 UTC

[jira] [Commented] (DIRKRB-214) Adding the UT ZookeeperBackendKdcTest

    [ https://issues.apache.org/jira/browse/DIRKRB-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492132#comment-14492132 ] 

Lin Chen commented on DIRKRB-214:
---------------------------------

Hi Jiajia,
The work looks great, a minor question: would it better to extract 
{code}
if(principalName.contains("/")) {
    principalName = principalName.replace("/", "\\");
}
{code} to a single method?

> Adding the UT ZookeeperBackendKdcTest
> -------------------------------------
>
>                 Key: DIRKRB-214
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-214
>             Project: Directory Kerberos
>          Issue Type: Test
>            Reporter: Jiajia Li
>            Assignee: Jiajia Li
>         Attachments: DIRKRB-214-V1.patch
>
>
> Adding the UT ZookeeperBackendKdcTest.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)