You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "xBis7 (via GitHub)" <gi...@apache.org> on 2025/05/01 10:36:36 UTC

Re: [PR] OpenTelemetry traces implementation cleanup [airflow]

xBis7 commented on code in PR #49180:
URL: https://github.com/apache/airflow/pull/49180#discussion_r2070138452


##########
airflow-core/tests/integration/otel/test_otel.py:
##########
@@ -1287,6 +1291,7 @@ def test_scheduler_exits_forcefully_in_the_middle_of_the_first_task(
             # Dag run should have succeeded. Test the spans in the output.
             check_spans_without_continuance(output=out, dag=dag, is_recreated=True, check_t1_sub_spans=False)
 
+    @pytest.mark.xfail(reason="Tests with a control file are flaky when running on the remote CI.")

Review Comment:
   I've removed the xfail annotations. I refactored the tests a bit and I was able to run the tests 5 times in a row successfully.
   
   https://github.com/apache/airflow/actions/runs/14759772893/job/41437793893?pr=49180
   
   https://github.com/xBis7/airflow/actions/runs/14759759875/job/41437846694
   
   https://github.com/xBis7/airflow/actions/runs/14760507799/job/41468986413
   
   https://github.com/xBis7/airflow/actions/runs/14760511337/job/41453655641
   
   https://github.com/xBis7/airflow/actions/runs/14760515145/job/41473346959



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org