You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ygerzhedovich (via GitHub)" <gi...@apache.org> on 2023/07/11 07:41:52 UTC
[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #2282: IGNITE-17298 Sql. Support BOOLEAN type.
ygerzhedovich commented on code in PR #2282:
URL: https://github.com/apache/ignite-3/pull/2282#discussion_r1259321937
##########
modules/api/src/main/java/org/apache/ignite/table/TupleImpl.java:
##########
@@ -180,6 +180,18 @@ public BinaryObject binaryObjectValue(int columnIndex) {
return value(columnIndex);
}
+ /** {@inheritDoc} */
+ @Override
+ public boolean booleanValue(@NotNull String columnName) {
Review Comment:
I suggest to remove NotNull annotation for whole file sue to our code style rules prohibit to use it - https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide#JavaCodeStyleGuide-2.1Commonannotatingrules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org