You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Yi Liu (JIRA)" <ji...@apache.org> on 2015/04/03 17:00:54 UTC

[jira] [Comment Edited] (HDFS-8058) Erasure coding: use BlockInfo[] for both striped and contiguous blocks in INodeFile

    [ https://issues.apache.org/jira/browse/HDFS-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394532#comment-14394532 ] 

Yi Liu edited comment on HDFS-8058 at 4/3/15 2:59 PM:
------------------------------------------------------

Attach the patch. 
In current logic, If file is striped, only {{BlockInfoStriped/BlockInfoStripedUnderConstruction}} can be added into {{BlockInfo[] blocks}}, and if file is contiguous, only {{BlockInfoContiguous/BlockInfoContiguousUnderConstruction}} can be added. So there is no problem doing like this.

[~jingzhao], [~zhz], please LMK what you think, thanks.


was (Author: hitliuyi):
Attach the patch. 
In current logic, If file is striped, only {{BlockInfoStriped/BlockInfoStripedUnderConstruction}} can be added into {{BlockInfo[] blocks}}, and if file is contiguous, only {{BlockInfoContiguous/BlockInfoContiguousUnderConstruction}} can be added. So there is no problem doing like this.

[~jingzhao], [~zhz], please LMK what you think.

> Erasure coding: use BlockInfo[] for both striped and contiguous blocks in INodeFile
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-8058
>                 URL: https://issues.apache.org/jira/browse/HDFS-8058
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7285
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>         Attachments: HDFS-8058.001.patch
>
>
> This JIRA is to use {{BlockInfo[] blocks}} for both striped and contiguous blocks in INodeFile.
> Currently {{FileWithStripedBlocksFeature}} keeps separate list for striped blocks, and the methods there duplicate with those in INodeFile, and current code need to judge {{isStriped}} then do different things. Also if file is striped, the {{blocks}} in INodeFile occupy a reference memory space.
> These are not necessary, and we can use the same {{blocks}} to make code more clear.
> I keep {{FileWithStripedBlocksFeature}} as empty for follow use: I will file a new JIRA to move {{dataBlockNum}} and {{parityBlockNum}} to INodeFile, since ideally they are the same for all striped blocks in a file, and store them in block will waste NN memory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)