[HOW TO FOLLOW GITHUB] Re: [PR] WIP: PIP-342: OTel client metrics support [pulsar]

[Dave Fisher <wa...@apache.org>]

For anyone who wishes to watch activity from with a Pulsar GitHub repository please consider subscribing to commits@pulsar.apache.org <ma...@pulsar.apache.org> by sending an email to commits-subscribe@pulsar.apache.org <ma...@pulsar.apache.org> and replying to a CONFIRM email.

Regards,
Dave

> On Mar 6, 2024, at 12:50 PM, asafm (via GitHub) <gi...@apache.org> wrote:
> 
> 
> asafm commented on code in PR #22179:
> URL: https://github.com/apache/pulsar/pull/22179#discussion_r1514920721
> 
> 
> ##########
> pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java:
> ##########
> @@ -451,15 +452,18 @@ ClientBuilder authentication(String authPluginClassName, Map<String, String> aut
>     ClientBuilder memoryLimit(long memoryLimit, SizeUnit unit);
> 
>     /**
> -     * Set the interval between each stat info <i>(default: 60 seconds)</i> Stats will be activated with positive
> +     * Set the interval between each stat info <i>(default: disabled)</i> Stats will be activated with positive
> 
> Review Comment:
>   How do we alert the users that those metrics are still subject to changes that may break them?
> 
> 
> 
> -- 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
> 
> To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
> 
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>