You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "himanshukandwal (via GitHub)" <gi...@apache.org> on 2024/06/04 18:00:26 UTC
[PR] [apache/helix] -- Enable JDK 1.8 (backward) compatibility for dependent modules of meta-client and helix-core [helix]
himanshukandwal opened a new pull request, #2806:
URL: https://github.com/apache/helix/pull/2806
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes https://github.com/apache/helix/issues/2779
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
We have some consumers which are still running their (open-source) systems on JRE-8, hence they are not able to run helix libraries compiled with JDK11+. We would like to provide a backward compatible support to our consumers where they also have an option to use JDK-8 compiled helix-core jar, if they have such a requirement. By default we will generate JDK-11 jars and JDK-8 jars using a classifier.
```
<major.minor.patch> will use JDK11 (default)
<major.minor.patch> classifier say jdk8 , will use JDK8
```
In this PR, we are enabling the the full sub-tree of the `helix-core` and `meta-client` modules. This includes:
- helix-common
- zookeeper-api
- metadata-store-directory-common
- metrics-common
### Tests
- [x] The following tests are written for this issue:
```
[INFO] --- install:2.5.2:install (default-install) @ helix-common ---
...
[INFO] Installing /Users/hkandwal/Documents/workspaces/projects/helix_os_hk/helix-common/target/helix-common-1.3.2-SNAPSHOT-jdk8.jar to /Users/hkandwal/.m2/repository/org/apache/helix/helix-common/1.3.2-SNAPSHOT/helix-common-1.3.2-SNAPSHOT-jdk8.jar
```
```
[INFO] --- install:2.5.2:install (default-install) @ zookeeper-api ---
...
[INFO] Installing /Users/hkandwal/Documents/workspaces/projects/helix_os_hk/zookeeper-api/target/zookeeper-api-1.3.2-SNAPSHOT-jdk8.jar to /Users/hkandwal/.m2/repository/org/apache/helix/zookeeper-api/1.3.2-SNAPSHOT/zookeeper-api-1.3.2-SNAPSHOT-jdk8.jar
```
```
[INFO]
[INFO] --- install:2.5.2:install (default-install) @ metadata-store-directory-common ---
...
/Users/hkandwal/.m2/repository/org/apache/helix/metadata-store-directory-common/1.3.2-SNAPSHOT/metadata-store-directory-common-1.3.2-SNAPSHOT-jdk8.jar
```
```
[INFO] --- install:2.5.2:install (default-install) @ metrics-common ---
...
[INFO] Installing /Users/hkandwal/Documents/workspaces/projects/helix_os_hk/metrics-common/target/metrics-common-1.3.2-SNAPSHOT-jdk8.jar to /Users/hkandwal/.m2/repository/org/apache/helix/metrics-common/1.3.2-SNAPSHOT/metrics-common-1.3.2-SNAPSHOT-jdk8.jar
```
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] [apache/helix] -- Enable JDK 1.8 (backward) compatibility for dependent modules of meta-client and helix-core [helix]
Posted by "junkaixue (via GitHub)" <gi...@apache.org>.
junkaixue merged PR #2806:
URL: https://github.com/apache/helix/pull/2806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] [apache/helix] -- Enable JDK 1.8 (backward) compatibility for dependent modules of meta-client and helix-core [helix]
Posted by "himanshukandwal (via GitHub)" <gi...@apache.org>.
himanshukandwal commented on PR #2806:
URL: https://github.com/apache/helix/pull/2806#issuecomment-2148731232
This PR is ready to be merged and has been approved by @junkaixue.
Final Commit Message:
We would like to provide a backward compatible support to our consumers where they also have an option to use JDK-8 compiled meta-client jar, if they have such a requirement. By default we will generate JDK-11 jars and JDK-8 jars using a classifier. In this PR, we are enabling the JDK* build of full sub-tree of the helix-core and meta-client modules. This includes:
helix-common, zookeeper-api, metadata-store-directory-common, metrics-common
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org