[GitHub] hughhhh commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #4890: [bugfix] temporal columns with expression fail
URL: https://github.com/apache/incubator-superset/pull/4890#discussion_r184537516
 
 

 ##########
 File path: tests/model_tests.py
 ##########
 @@ -105,3 +105,9 @@ def test_grains_dict(self):
         self.assertEquals(d.get('day').function, 'DATE({col})')
         self.assertEquals(d.get('P1D').function, 'DATE({col})')
         self.assertEquals(d.get('Time Column').function, '{col}')
+
+    def test_get_timestamp_expression(self):
+        tbl = self.get_table_by_name('birth_names')
+        ds_col = tbl.get_column('ds')
+        sqla_literal = ds_col.get_timestamp_expression(None)
 
 Review comment:
   Can we add a test thats passing a value into `get_timestamp_expression()` to make sure we are returning the proper `literal_col`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services