You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2011/05/05 08:06:05 UTC

svn commit: r1099694 - in /hbase/branches/0.90: CHANGES.txt src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java

Author: stack
Date: Thu May  5 06:06:05 2011
New Revision: 1099694

URL: http://svn.apache.org/viewvc?rev=1099694&view=rev
Log:
HBASE-3813 Change RPC callQueue size from "handlerCount * MAX_QUEUE_SIZE_PER_HANDLER;"; stopgap fix for now

Modified:
    hbase/branches/0.90/CHANGES.txt
    hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java

Modified: hbase/branches/0.90/CHANGES.txt
URL: http://svn.apache.org/viewvc/hbase/branches/0.90/CHANGES.txt?rev=1099694&r1=1099693&r2=1099694&view=diff
==============================================================================
--- hbase/branches/0.90/CHANGES.txt (original)
+++ hbase/branches/0.90/CHANGES.txt Thu May  5 06:06:05 2011
@@ -57,6 +57,8 @@ Release 0.90.3 - Unreleased
    HBASE-3805  Log RegionState that are processed too late in the master
    HBASE-3695  Some improvements to Hbck to test the entire region chain
                in Meta and provide better error reporting (Marc Limotte)
+   HBASE-3813  Change RPC callQueue size from 'handlerCount *
+               MAX_QUEUE_SIZE_PER_HANDLER;'
 
   TASK
    HBASE-3748  Add rolling of thrift/rest daemons to graceful_stop.sh script

Modified: hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java?rev=1099694&r1=1099693&r2=1099694&view=diff
==============================================================================
--- hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java (original)
+++ hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java Thu May  5 06:06:05 2011
@@ -90,7 +90,7 @@ public abstract class HBaseServer {
   /**
    * How many calls/handler are allowed in the queue.
    */
-  private static final int MAX_QUEUE_SIZE_PER_HANDLER = 100;
+  private static final int DEFAULT_MAX_QUEUE_SIZE_PER_HANDLER = 10;
 
   private static final String WARN_RESPONSE_SIZE =
       "hbase.ipc.warn.response.size";
@@ -1147,7 +1147,9 @@ public abstract class HBaseServer {
     this.handlerCount = handlerCount;
     this.priorityHandlerCount = priorityHandlerCount;
     this.socketSendBufferSize = 0;
-    this.maxQueueSize = handlerCount * MAX_QUEUE_SIZE_PER_HANDLER;
+    this.maxQueueSize =
+      this.conf.getInt("ipc.server.max.queue.size",
+        handlerCount * DEFAULT_MAX_QUEUE_SIZE_PER_HANDLER);
      this.readThreads = conf.getInt(
         "ipc.server.read.threadpool.size",
         10);