You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Mike Rheinheimer (JIRA)" <ji...@apache.org> on 2010/06/30 21:47:50 UTC
[jira] Created: (WINK-297) serviceability improvement; externalize
strings, confirm formatting
serviceability improvement; externalize strings, confirm formatting
-------------------------------------------------------------------
Key: WINK-297
URL: https://issues.apache.org/jira/browse/WINK-297
Project: Wink
Issue Type: Improvement
Components: Client, Common, Server
Affects Versions: 1.1.2
Reporter: Mike Rheinheimer
Assignee: Mike Rheinheimer
Fix For: 1.1.2
We've needed serviceability improvements for a while. Here's the first pass. I've externalized all strings that should be externalized, marked the rest with //$NON-NLS-#$ via Eclipse's tool, and here's the cool part: wrote a unittest to do the following:
1) checks that the strings that should be externalized are externalized (only debug messages do not need to be externalized)
2) checks that all keys referred to by Messages.getMessage actually exist
3) checks that there are no unused keys in the resource.properties file
4) checks that the number of params matches up with the number of braces {} in a formatted log string, both externalized and non-externalized
See attached patch. The test is under org.apache.wink.common.internal.i18n.MessagesTest.
I'll wait to commit this until the 1.1.1 release vote and process is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-297) serviceability improvement; externalize
strings, confirm formatting
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer resolved WINK-297.
-----------------------------------
Resolution: Fixed
Committed in SVN rev 960918.
> serviceability improvement; externalize strings, confirm formatting
> -------------------------------------------------------------------
>
> Key: WINK-297
> URL: https://issues.apache.org/jira/browse/WINK-297
> Project: Wink
> Issue Type: Improvement
> Components: Client, Common, Server
> Affects Versions: 1.1.2
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Fix For: 1.1.2
>
> Attachments: WINK-297.patch
>
>
> We've needed serviceability improvements for a while. Here's the first pass. I've externalized all strings that should be externalized, marked the rest with //$NON-NLS-#$ via Eclipse's tool, and here's the cool part: wrote a unittest to do the following:
> 1) checks that the strings that should be externalized are externalized (only debug messages do not need to be externalized)
> 2) checks that all keys referred to by Messages.getMessage actually exist
> 3) checks that there are no unused keys in the resource.properties file
> 4) checks that the number of params matches up with the number of braces {} in a formatted log string, both externalized and non-externalized
> See attached patch. The test is under org.apache.wink.common.internal.i18n.MessagesTest.
> I'll wait to commit this until the 1.1.1 release vote and process is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-297) serviceability improvement;
externalize strings, confirm formatting
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885613#action_12885613 ]
Hudson commented on WINK-297:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #361 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/361/])
WINK-297: externalize all hard-coded strings for translation, ensure all key/value pairs are used, formatting is correct, add a test
> serviceability improvement; externalize strings, confirm formatting
> -------------------------------------------------------------------
>
> Key: WINK-297
> URL: https://issues.apache.org/jira/browse/WINK-297
> Project: Wink
> Issue Type: Improvement
> Components: Client, Common, Server
> Affects Versions: 1.1.2
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Fix For: 1.1.2
>
> Attachments: WINK-297.patch
>
>
> We've needed serviceability improvements for a while. Here's the first pass. I've externalized all strings that should be externalized, marked the rest with //$NON-NLS-#$ via Eclipse's tool, and here's the cool part: wrote a unittest to do the following:
> 1) checks that the strings that should be externalized are externalized (only debug messages do not need to be externalized)
> 2) checks that all keys referred to by Messages.getMessage actually exist
> 3) checks that there are no unused keys in the resource.properties file
> 4) checks that the number of params matches up with the number of braces {} in a formatted log string, both externalized and non-externalized
> See attached patch. The test is under org.apache.wink.common.internal.i18n.MessagesTest.
> I'll wait to commit this until the 1.1.1 release vote and process is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-297) serviceability improvement; externalize
strings, confirm formatting
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer closed WINK-297.
---------------------------------
> serviceability improvement; externalize strings, confirm formatting
> -------------------------------------------------------------------
>
> Key: WINK-297
> URL: https://issues.apache.org/jira/browse/WINK-297
> Project: Wink
> Issue Type: Improvement
> Components: Client, Common, Server
> Affects Versions: 1.1.2
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Fix For: 1.1.2
>
> Attachments: WINK-297.patch
>
>
> We've needed serviceability improvements for a while. Here's the first pass. I've externalized all strings that should be externalized, marked the rest with //$NON-NLS-#$ via Eclipse's tool, and here's the cool part: wrote a unittest to do the following:
> 1) checks that the strings that should be externalized are externalized (only debug messages do not need to be externalized)
> 2) checks that all keys referred to by Messages.getMessage actually exist
> 3) checks that there are no unused keys in the resource.properties file
> 4) checks that the number of params matches up with the number of braces {} in a formatted log string, both externalized and non-externalized
> See attached patch. The test is under org.apache.wink.common.internal.i18n.MessagesTest.
> I'll wait to commit this until the 1.1.1 release vote and process is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-297) serviceability improvement; externalize
strings, confirm formatting
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated WINK-297:
----------------------------------
Attachment: WINK-297.patch
> serviceability improvement; externalize strings, confirm formatting
> -------------------------------------------------------------------
>
> Key: WINK-297
> URL: https://issues.apache.org/jira/browse/WINK-297
> Project: Wink
> Issue Type: Improvement
> Components: Client, Common, Server
> Affects Versions: 1.1.2
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Fix For: 1.1.2
>
> Attachments: WINK-297.patch
>
>
> We've needed serviceability improvements for a while. Here's the first pass. I've externalized all strings that should be externalized, marked the rest with //$NON-NLS-#$ via Eclipse's tool, and here's the cool part: wrote a unittest to do the following:
> 1) checks that the strings that should be externalized are externalized (only debug messages do not need to be externalized)
> 2) checks that all keys referred to by Messages.getMessage actually exist
> 3) checks that there are no unused keys in the resource.properties file
> 4) checks that the number of params matches up with the number of braces {} in a formatted log string, both externalized and non-externalized
> See attached patch. The test is under org.apache.wink.common.internal.i18n.MessagesTest.
> I'll wait to commit this until the 1.1.1 release vote and process is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.