You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/23 16:35:03 UTC

[GitHub] brodybits edited a comment on issue #576: Improve target-dir restriction for detecting new android project…

brodybits edited a comment on issue #576: Improve target-dir restriction for detecting new android project…
URL: https://github.com/apache/cordova-android/pull/576#issuecomment-441279711
 
 
   Thanks @Jule- for the contribution. I think you are right that we need to handle the case where `target-dir` with character other than `/` after `app`. But I think we are missing the answers to the questions I asked.
   
   While reviewing the code related to this contribution I discovered another fix needed, raised in PR #577.
   
   I think we should consider throwing an exception, emitting an error, and aborting the `cordova plugin add` command with an error status in case of `target-dir` that does not start with a valid prefix.
   
   P.S. I just raised #578 to report error handling that may be needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org