You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/10/21 04:39:38 UTC
Review Request 39507: Check message.empty() in Slave::shutdown before
log it
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39507/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-3769
https://issues.apache.org/jira/browse/MESOS-3769
Repository: mesos
Description
-------
Check message.empty() in Slave::shutdown before log it
Diffs
-----
src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3
Diff: https://reviews.apache.org/r/39507/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 39507: Check message.empty() in Slave::shutdown
before log it
Posted by Guangya Liu <gy...@gmail.com>.
> On 十月 21, 2015, 4:58 p.m., Alexander Rukletsov wrote:
> > src/slave/slave.cpp, line 652
> > <https://reviews.apache.org/r/39507/diff/1/?file=1102249#file1102249line652>
> >
> > Capitalize?
If the message is empty, we can use capitalize, otherwise we cannot. Will update this patch.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39507/#review103430
-----------------------------------------------------------
On 十月 21, 2015, 2:39 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39507/
> -----------------------------------------------------------
>
> (Updated 十月 21, 2015, 2:39 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-3769
> https://issues.apache.org/jira/browse/MESOS-3769
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Check message.empty() in Slave::shutdown before log it
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3
>
> Diff: https://reviews.apache.org/r/39507/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39507: Check message.empty() in Slave::shutdown
before log it
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39507/#review103430
-----------------------------------------------------------
src/slave/slave.cpp (line 652)
<https://reviews.apache.org/r/39507/#comment161483>
Capitalize?
src/slave/slave.cpp (line 658)
<https://reviews.apache.org/r/39507/#comment161484>
Ditto
- Alexander Rukletsov
On Oct. 21, 2015, 2:39 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39507/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 2:39 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-3769
> https://issues.apache.org/jira/browse/MESOS-3769
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Check message.empty() in Slave::shutdown before log it
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3
>
> Diff: https://reviews.apache.org/r/39507/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39507: Check message.empty() in Slave::shutdown
before log it
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39507/#review103385
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39507]
All tests passed.
- Mesos ReviewBot
On Oct. 21, 2015, 2:39 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39507/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 2:39 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-3769
> https://issues.apache.org/jira/browse/MESOS-3769
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Check message.empty() in Slave::shutdown before log it
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3
>
> Diff: https://reviews.apache.org/r/39507/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39507: Check message.empty() in Slave::shutdown
before log it
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39507/#review103356
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Oct. 21, 2015, 2:39 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39507/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 2:39 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-3769
> https://issues.apache.org/jira/browse/MESOS-3769
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Check message.empty() in Slave::shutdown before log it
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3
>
> Diff: https://reviews.apache.org/r/39507/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39507: Check message.empty() in Slave::shutdown
before log it
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39507/#review103519
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39507]
All tests passed.
- Mesos ReviewBot
On Oct. 22, 2015, 2:14 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39507/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 2:14 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-3769
> https://issues.apache.org/jira/browse/MESOS-3769
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Check message.empty() in Slave::shutdown before log it
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a
>
> Diff: https://reviews.apache.org/r/39507/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39507: Check message.empty() in Slave::shutdown
before log it
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39507/#review104509
-----------------------------------------------------------
Till, can you please help check if can be merged? Thanks!
- Guangya Liu
On Oct. 22, 2015, 2:14 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39507/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 2:14 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-3769
> https://issues.apache.org/jira/browse/MESOS-3769
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Check message.empty() in Slave::shutdown before log it
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a
>
> Diff: https://reviews.apache.org/r/39507/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39507: Check message.empty() in Slave::shutdown
before log it
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39507/
-----------------------------------------------------------
(Updated 十月 22, 2015, 2:14 a.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Address Alex's comments
Bugs: MESOS-3769
https://issues.apache.org/jira/browse/MESOS-3769
Repository: mesos
Description
-------
Check message.empty() in Slave::shutdown before log it
Diffs (updated)
-----
src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a
Diff: https://reviews.apache.org/r/39507/diff/
Testing
-------
Thanks,
Guangya Liu