You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/14 18:44:07 UTC

[GitHub] [geode] rhoughton-pivot commented on a diff in pull request #7587: GEODE-10035: fix BufferPool sys prop logic

rhoughton-pivot commented on code in PR #7587:
URL: https://github.com/apache/geode/pull/7587#discussion_r850712534


##########
geode-core/src/test/java/org/apache/geode/internal/net/BufferPoolTest.java:
##########
@@ -15,78 +15,80 @@
 
 package org.apache.geode.internal.net;
 
+import static org.apache.geode.util.internal.GeodeGlossary.GEMFIRE_PREFIX;

Review Comment:
   Since the symbol for GEMFIRE_PREFIX is internal, any chance we can use this opportunity to scrub it from the codebase and use GEODE_PREFIX instead?
   
   Is it worth it?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org