You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/23 11:14:38 UTC

[GitHub] cclauss commented on a change in pull request #12295: [MXNET-696] Define cmp() in Python 3 again

cclauss commented on a change in pull request #12295: [MXNET-696] Define cmp() in Python 3 again
URL: https://github.com/apache/incubator-mxnet/pull/12295#discussion_r212270403
 
 

 ##########
 File path: tests/nightly/model_backwards_compatibility_check/common.py
 ##########
 @@ -29,6 +29,13 @@
 import re
 from mxnet.test_utils import assert_almost_equal
 
+try:
 
 Review comment:
   1. It is a Python 3 syntax error
   2. With the syntax fixed it generates a PEP8 violation in flake8 https://stackoverflow.com/questions/25010167/e731-do-not-assign-a-lambda-expression-use-a-def

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services