[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5240: GEODE-8242: Add HSTRLEN redis command

[GitBox <gi...@apache.org>]

jdeppe-pivotal commented on a change in pull request #5240:
URL: https://github.com/apache/geode/pull/5240#discussion_r440367035



##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/HashesIntegrationTest.java
##########
@@ -150,6 +150,15 @@ public void testHDelDeletesKeyWhenHashIsEmpty() {
     assertThat(jedis.exists("farm")).isFalse();
   }
 
+  @Test
+  public void testHStrLen() {
+    jedis.hset("farm", "chicken", "little");
+
+    assertThat(jedis.hstrlen("farm", "chicken")).isEqualTo("little".length());
+    assertThat(jedis.hstrlen("farm", "unknown-field")).isEqualTo(0);
+    assertThat(jedis.hstrlen("unknown-key", "unknown-field")).isEqualTo(0);
+  }

Review comment:
       We can do something like `jedis.sendCommand(Command.STRLEN, "foo", "bar", ...)` but we don't have explicit tests for command input lengths. The are tested implicitly through the parameter requirements defined against each command in `RedisCommandType`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org