[GitHub] [ozone] elek commented on a change in pull request #2287: HDDS-5168. Use ReplicationConfig in OmKeyArgs

[GitBox <gi...@apache.org>]

elek commented on a change in pull request #2287:
URL: https://github.com/apache/ozone/pull/2287#discussion_r643931964



##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneMultipartUploadPartListParts.java
##########
@@ -77,8 +79,16 @@ public boolean isTruncated() {
     return partInfoList;
   }
 
+  @Deprecated
+  public ReplicationType getReplicationType() {
+    return ReplicationType
+            .fromProto(replicationConfig.getReplicationType());
+  }
+
+  @Deprecated
   public ReplicationFactor getReplicationFactor() {
-    return replicationFactor;
+    return ReplicationFactor
+            .fromProto(ReplicationConfig.getLegacyFactor(replicationConfig));
   }

Review comment:
       Sure, I added the getter. It's not yet used, but can be useful for users of the Java API.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org