You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Wojtek Piaseczny (JIRA)" <ji...@apache.org> on 2009/04/30 21:03:30 UTC
[jira] Issue Comment Edited: (SOLR-748) FacetComponent helper
classes are package restricted
[ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704748#action_12704748 ]
Wojtek Piaseczny edited comment on SOLR-748 at 4/30/09 12:03 PM:
-----------------------------------------------------------------
Patch implements Shalin's suggested changes.
was (Author: wojtekpia):
Path implements Shalin's suggested changes.
> FacetComponent helper classes are package restricted
> ----------------------------------------------------
>
> Key: SOLR-748
> URL: https://issues.apache.org/jira/browse/SOLR-748
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Wojtek Piaseczny
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: 748.patch, SOLR-748.patch, SOLR-748.patch, SOLR-748.patch, SOLR-748.patch
>
>
> Original discussion:
> http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html
> The FacetComponent class uses several helper classes that currently have package-restricted access. This makes it impossible to extend the FacetComponent without rewriting most of its functionality.
> A proposed solution is to make those classes public and make their public member variables accessibly only through get and set functions (i.e. make them private).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.