You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Rishabh00b (via GitHub)" <gi...@apache.org> on 2026/10/20 02:35:50 UTC
[PR] Validate the file structure in airflowctl connections import [airflow]
Rishabh00b opened a new pull request, #75176:
URL: https://github.com/apache/airflow/pull/75176
`airflowctl connections import` assumed the file was a JSON object of objects. A file holding a list, a scalar, or an entry that is not an object failed with internal messages such as `'list' object has no attribute 'items'` or `'str' object has no attribute 'get'`.
This checks the structure right after parsing, before any request is built, and exits with a message naming the file, the offending connection id and the expected shape. `variables import` and `pools import` already validate their input the same way. No request is sent for a malformed file.
**Testing:** 4 new tests in `test_connections_command.py` (fail without the change, pass with it). `ruff check`, `ruff format --check` and `mypy` pass. The full `airflow-ctl` suite gives 444 passed and 1 failed; that failure (`test_import_rejects_non_object_json`) also occurs on `main` because my sandbox has no keyring backend. I did not run `prek` or Breeze.
**Was generative AI tooling used to co-author this PR?**
- [X] Yes (Claude Code, Claude Sonnet 5.5)
Generated-by: Claude Code (Claude Sonnet 5.5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01PLWtW8cKWizvRLaFPf8BQD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Validate the file structure in airflowctl connections import [airflow]
Posted by "boring-cyborg[bot] (via GitHub) via commits" <co...@airflow.apache.org>.
boring-cyborg[bot] commented on PR #75176:
URL: https://github.com/apache/airflow/pull/75176#issuecomment-6533175317
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Validate the file structure in airflowctl connections import [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #75176:
URL: https://github.com/apache/airflow/pull/75176#issuecomment-6282014852
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Validate the file structure in airflowctl connections import [airflow]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@airflow.apache.org>.
github-actions[bot] commented on PR #75176:
URL: https://github.com/apache/airflow/pull/75176#issuecomment-6533205035
### Backport successfully created: airflow-ctl/v0-1-test
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>airflow-ctl/v0-1-test</td>
<td><a href="https://github.com/apache/airflow/pull/76088"><img src="https://img.shields.io/badge/PR-76088-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Validate the file structure in airflowctl connections import [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #75176:
URL: https://github.com/apache/airflow/pull/75176#issuecomment-6444174829
Undrafted as I'd like to include this in the airflowctl 0.1.6 release :)
I'll review when CI finishes running
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Validate the file structure in airflowctl connections import [airflow]
Posted by "shahar1 (via GitHub) via commits" <co...@airflow.apache.org>.
shahar1 merged PR #75176:
URL: https://github.com/apache/airflow/pull/75176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org