[PR] [release] Exclude xtable-service/examples screenshots from source release tarball [incubator-xtable]

["vinishjail97 (via GitHub)" <gi...@apache.org>]

vinishjail97 opened a new pull request, #852:
URL: https://github.com/apache/incubator-xtable/pull/852

   ## What is the purpose of the pull request
   
   The source-release tarball is built by `release/scripts/create_source_release.sh`, which rsyncs the tree with a set of `--exclude` patterns. The `xtable-service/examples/` directory (added in #704) contains binary PNG screenshots, so they end up in the source tarball and fail the project's own `validate_source_binary_files.sh` check during `validate_staged_release.sh` — an ASF source release must be source-only.
   
   This adds `--exclude "xtable-service/examples"` alongside the existing exclusions (e.g. `assets`, `demo`, `website`, `style/IDE.png`), so the screenshots stay in the repo but are kept out of the source release.
   
   Found while cutting `0.4.0-incubating-rc1`; the same fix is already on `branch-0.4` (commit that unblocked rc1). This brings `main` in line so the next release from `main` doesn't hit the same blocker.
   
   ## Verify this pull request
   
   Ran `create_source_release.sh` with the change and confirmed the produced tarball contains no `.png`/`examples` paths and passes `validate_source_binary_files.sh`.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [855] Fix release scripts: exclude xtable-service/examples + repair deploy_staging_jars.sh [incubator-xtable]

["vinothchandar (via GitHub)" <gi...@apache.org>]

vinothchandar commented on code in PR #852:
URL: https://github.com/apache/incubator-xtable/pull/852#discussion_r3626268904


##########
release/scripts/deploy_staging_jars.sh:
##########
@@ -39,18 +39,19 @@ if [ "${1:-}" == "-h" ]; then
 Usage: $(basename "$0") [OPTIONS]
 
 Options:
-<version option>  One of the version options below
-${joined}
 -h, --help
 "
   exit 0
 fi
 
 
-COMMON_OPTIONS="-DdeployArtifacts=true -DskipTests -DretryFailedDeploymentCount=10"
+# -Dmaven.build.cache.enabled=false: the build cache (.mvn/extensions.xml) restores the

Review Comment:
   reasoning makes sense



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [855] Fix release scripts: exclude xtable-service/examples + repair deploy_staging_jars.sh [incubator-xtable]

["vinishjail97 (via GitHub)" <gi...@apache.org>]

vinishjail97 merged PR #852:
URL: https://github.com/apache/incubator-xtable/pull/852


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org