You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/18 17:22:21 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2027: Documentation: Reorganize some section
xiaoxiang781216 opened a new pull request #2027:
URL: https://github.com/apache/incubator-nuttx/pull/2027
## Summary
1.note, socketcan and syslog should put into driver section
2.nsh should put into application section
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2027: Documentation: Reorganize some section
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2027:
URL: https://github.com/apache/incubator-nuttx/pull/2027#discussion_r507513151
##########
File path: Documentation/components/drivers/special/index.rst
##########
@@ -22,9 +22,11 @@ following section.
.. toctree::
:caption: Supported Drivers
+ syslog.rst
spi.rst
i2c.rst
ethernet.rst
+ socketcan.rst
Review comment:
@btashton and @v01d do you know why syslog.rst, socketcan.rst can't show on the website?
https://nuttx.apache.org/docs/latest/components/drivers/special/index.html
even the source show that they are there:
https://nuttx.apache.org/docs/latest/_sources/components/drivers/special/index.rst.txt
nsh has the similar issue, but note.rst don't, very strange.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2027: Documentation: Reorganize some section
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #2027:
URL: https://github.com/apache/incubator-nuttx/pull/2027#discussion_r507702725
##########
File path: Documentation/components/drivers/special/index.rst
##########
@@ -22,9 +22,11 @@ following section.
.. toctree::
:caption: Supported Drivers
+ syslog.rst
spi.rst
i2c.rst
ethernet.rst
+ socketcan.rst
Review comment:
@xiaoxiang781216 try to do "CTRL+SHIT+R", this forces the browser to reload and not use cache. I've seen this happen some times on Firefox at least. I wonder if we need some extra tag on the HTMLs to make the server know about the changed HTML
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2027: Documentation: Reorganize some section
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #2027:
URL: https://github.com/apache/incubator-nuttx/pull/2027#discussion_r507514484
##########
File path: Documentation/components/drivers/special/index.rst
##########
@@ -22,9 +22,11 @@ following section.
.. toctree::
:caption: Supported Drivers
+ syslog.rst
spi.rst
i2c.rst
ethernet.rst
+ socketcan.rst
Review comment:
https://nuttx.apache.org/docs/latest/components/drivers/special/socketcan.html
I see it here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #2027: Documentation: Reorganize some section
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2027:
URL: https://github.com/apache/incubator-nuttx/pull/2027
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2027: Documentation: Reorganize some section
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2027:
URL: https://github.com/apache/incubator-nuttx/pull/2027#discussion_r507546656
##########
File path: Documentation/components/drivers/special/index.rst
##########
@@ -22,9 +22,11 @@ following section.
.. toctree::
:caption: Supported Drivers
+ syslog.rst
spi.rst
i2c.rst
ethernet.rst
+ socketcan.rst
Review comment:
My sceenshot at https://nuttx.apache.org/docs/latest/components/drivers/special/index.html:
My sceenshot at https://nuttx.apache.org/docs/latest/components/drivers/special/socketcan.html:
Very strange.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2027: Documentation: Reorganize some section
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2027:
URL: https://github.com/apache/incubator-nuttx/pull/2027#discussion_r507738811
##########
File path: Documentation/components/drivers/special/index.rst
##########
@@ -22,9 +22,11 @@ following section.
.. toctree::
:caption: Supported Drivers
+ syslog.rst
spi.rst
i2c.rst
ethernet.rst
+ socketcan.rst
Review comment:
Yes, reload can work! Thanks, @v01d.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org