[jira] [Commented] (HBASE-17531) Memory tuning should account for undefined max heap

["Sean Busbey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838046#comment-15838046 ] 

Sean Busbey commented on HBASE-17531:
-------------------------------------

The logic in {{CacheConfig}} disables the L1 cache if we get an undefined for Max Heap.

> Memory tuning should account for undefined max heap
> ---------------------------------------------------
>
>                 Key: HBASE-17531
>                 URL: https://issues.apache.org/jira/browse/HBASE-17531
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Sean Busbey
>
> While going through HBASE-17522, I noticed that our calculations for heap usage don't account for the JVM returning a -1 to mean "undefined" for the max heap. for example, {{getOnheapGlobalMemstoreSize}} just does the calculation as it would if a normal number is returned, which means we end up with -1 or 0 and then the logic in {{RegionServerAccounting.isAboveHighWaterMark()}} is always going to say "we need to flush".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)