You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/17 03:27:40 UTC

[GitHub] [incubator-nuttx] royfengsss commented on a change in pull request #2269: xtensa/esp32: Add high memory support to work with PSRAM

royfengsss commented on a change in pull request #2269:
URL: https://github.com/apache/incubator-nuttx/pull/2269#discussion_r524861218



##########
File path: arch/xtensa/src/esp32/esp32_psram.c
##########
@@ -1530,7 +1530,7 @@ psram_enable(int mode, int vaddrmode)   /* psram init */
         PSRAM_IS_64MBIT_TRIAL(s_psram_id)))
     {
 #if defined(CONFIG_ESP32_SPIRAM_2T_MODE)
-#  if CONFIG_ESP32_SPIRAM_BANKSWITCH_ENABLE
+#  if CONFIG_SPIRAM_BANKSWITCH_ENABLE

Review comment:
       CONFIG_SPIRAM_BANKSWITCH_ENABLE or CONFIG_ESP32_SPIRAM_BANKSWITCH_ENABLE?
   In arch/xtensa/src/esp32/Kconfig, this configure option changed to ESP32_SPIRAM_BANKSWITCH_ENABLE
   
   Please kindly check.
   
   Thanks

##########
File path: boards/xtensa/esp32/esp32-core/src/esp32_bringup.c
##########
@@ -143,7 +143,7 @@ int esp32_bringup(void)
 
 #endif
 
-#if defined(CONFIG_ESP32_SPIRAM)
+#if defined(CONFIG_ESP32_SPIRAM) && defined(CONFIG_SPIRAM_BANKSWITCH_ENABLE)

Review comment:
       CONFIG_SPIRAM_BANKSWITCH_ENABLE or CONFIG_ESP32_SPIRAM_BANKSWITCH_ENABLE?
   In _arch/xtensa/src/esp32/Kconfig_, this configure option changed to ESP32_SPIRAM_BANKSWITCH_ENABLE
   
   Please kindly check.
   
   Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org