[GitHub] hughhhh commented on a change in pull request #6526: Hotkeys in Explore View

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #6526: Hotkeys in Explore View
URL: https://github.com/apache/incubator-superset/pull/6526#discussion_r241907086
 
 

 ##########
 File path: superset/assets/src/explore/components/ExploreViewContainer.jsx
 ##########
 @@ -17,6 +18,16 @@ import * as saveModalActions from '../actions/saveModalActions';
 import * as chartActions from '../../chart/chartAction';
 import { fetchDatasourceMetadata } from '../../dashboard/actions/datasources';
 import { Logger, ActionLog, EXPLORE_EVENT_NAMES, LOG_ACTIONS_MOUNT_EXPLORER } from '../../logger';
+import { match } from '../../utils/common';
+
+// Prolly need to move this to a global context
+const keymap = {
+  EXPLORE: {
+    RUN: ['command+enter'],
+    SAVE: ['command+shift'],
 
 Review comment:
   From a user standpoint i think shift is easier, but we can go to s and i'll figure out a way to override the setttings from `superset_config.py` :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org