You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/10 12:01:28 UTC
[GitHub] [druid] clintropolis opened a new pull request #10017: ignore brokers in broker views
clintropolis opened a new pull request #10017:
URL: https://github.com/apache/druid/pull/10017
### Description
This PR fixes a fun issue introduced by #9971, which added the ability for realtime tasks and brokers to load broadcast segments, which is totally neat, but, was missing a couple of pieces. The missing piece being fixed here is for `BrokerServerView` and `DruidSchema` to ignore brokers so that they don't try to query themselves infinitely, or get metadata from themselves infinitely (well, at least until jetty gets really really sad).
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
<hr>
##### Key changed/added classes in this PR
* `BrokerServerView`
* `DruidSchema`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei merged pull request #10017: ignore brokers in broker views
Posted by GitBox <gi...@apache.org>.
jon-wei merged pull request #10017:
URL: https://github.com/apache/druid/pull/10017
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org