You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by hasalex <gi...@git.apache.org> on 2017/06/26 07:17:00 UTC
[GitHub] tomcat pull request #68: Fix #61224 - Make the GlobalRequestProcessor mbeans...
GitHub user hasalex opened a pull request:
https://github.com/apache/tomcat/pull/68
Fix #61224 - Make the GlobalRequestProcessor mbeans read-only
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hasalex/tomcat GlobalRequestProcessor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
----
commit 54156d4a63ac60cf10f83758117a53ea93f317b7
Author: Alexis Hassler <al...@sewatech.fr>
Date: 2017-06-26T06:49:04Z
Fix #61224 - Make the GlobalRequestProcessor mbeans read-only
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request #68: Fix #61224 - Make the GlobalRequestProcessor mbeans...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tomcat/pull/68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #68: Fix #61224 - Make the GlobalRequestProcessor mbeans read-o...
Posted by hasalex <gi...@git.apache.org>.
Github user hasalex commented on the issue:
https://github.com/apache/tomcat/pull/68
Thanks for fixing (and merging) the PR
It worked on my machine ;) I'll have to learn more on the build process.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #68: Fix #61224 - Make the GlobalRequestProcessor mbeans read-o...
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/68
Tomcat fails to compile after applying this patch.
Looking in to this, I don't see any reason for BaseModelMBean to throw exceptions in its constructor. As far as I can tell, the constructor (and the matching constructors on all the sub-classes) can be removed.
I'm going to look into this before coming back to this PR. No need to update the PR. The changes required are minor enough that I'll handle it on merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org