You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/12 20:49:00 UTC

[jira] [Commented] (MINIFICPP-313) GenerateFlowFile 'Unique FlowFiles' property inverted

    [ https://issues.apache.org/jira/browse/MINIFICPP-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324540#comment-16324540 ] 

ASF GitHub Bot commented on MINIFICPP-313:
------------------------------------------

GitHub user dtrodrigues opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/240

    MINIFICPP-313: correctly implement unique flowfiles param for GenerateFlowFile

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-313

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/240.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #240
    
----
commit 6ac3279d62e1e511d8a5b8f3cef149816510a31b
Author: Dustin Rodrigues <du...@...>
Date:   2018-01-12T20:47:37Z

    MINIFICPP-313: correctly implement unique flowfiles param for GenerateFlowFile

----


> GenerateFlowFile 'Unique FlowFiles' property inverted
> -----------------------------------------------------
>
>                 Key: MINIFICPP-313
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-313
>             Project: NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: Andrew Christianson
>            Priority: Minor
>             Fix For: 0.4.0
>
>
> 'Unique FlowFiles' must be set to false in order to get unique flow files, which is backward.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)