You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2012/05/04 09:04:53 UTC

[jira] [Commented] (THRIFT-1592) Test clients should have a return codes that reflect whether they succeeded or not

    [ https://issues.apache.org/jira/browse/THRIFT-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268183#comment-13268183 ] 

Hudson commented on THRIFT-1592:
--------------------------------

Integrated in Thrift #453 (See [https://builds.apache.org/job/Thrift/453/])
    THRIFT-1592 Test clients should have a return codes that reflect whether they succeeded or not
Patch: Nathaniel Cook (Revision 1333765)

     Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1333765
Files : 
* /thrift/trunk/test/cpp/src/TestClient.cpp

                
> Test clients should have a return codes that reflect whether they succeeded or not 
> -----------------------------------------------------------------------------------
>
>                 Key: THRIFT-1592
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1592
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Test Suite
>    Affects Versions: 0.9
>            Reporter: Nathaniel Cook
>            Assignee: Nathaniel Cook
>              Labels: test
>         Attachments: THRIFT-1592_cpp.patch
>
>
> Currently test.sh checks the return code of the various test clients to determine whether they succeeded. Since we can now standardize our tests across languages (THRIFT-1590) we should actually check the return values of the various calls and then use an appropriate error code to indicate if all the tests passed or not. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira