You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/07 23:07:57 UTC
[GitHub] [beam] robertwb opened a new pull request, #23073: Use cloudpickle for Java Python transforms.
robertwb opened a new pull request, #23073:
URL: https://github.com/apache/beam/pull/23073
This works around bugs in dill regarding functions defined with eval and exec used for the PythonCallable types here.
Also fix flag that was placed on the wrong binary.
This is a follow-up to https://github.com/apache/beam/pull/22999
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb merged pull request #23073: Use cloudpickle for Java Python transforms.
Posted by GitBox <gi...@apache.org>.
robertwb merged PR #23073:
URL: https://github.com/apache/beam/pull/23073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on a diff in pull request #23073: Use cloudpickle for Java Python transforms.
Posted by GitBox <gi...@apache.org>.
ihji commented on code in PR #23073:
URL: https://github.com/apache/beam/pull/23073#discussion_r965454344
##########
sdks/python/apache_beam/runners/portability/expansion_service_main.py:
##########
@@ -39,10 +40,14 @@ def main(argv):
parser.add_argument(
'-p', '--port', type=int, help='port on which to serve the job api')
parser.add_argument('--fully_qualified_name_glob', default=None)
+ parser.add_argument('--default_pickler')
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23073: Use cloudpickle for Java Python transforms.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23073:
URL: https://github.com/apache/beam/pull/23073#issuecomment-1240008718
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #23073: Use cloudpickle for Java Python transforms.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #23073:
URL: https://github.com/apache/beam/pull/23073#issuecomment-1240020620
# [Codecov](https://codecov.io/gh/apache/beam/pull/23073?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23073](https://codecov.io/gh/apache/beam/pull/23073?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c3048b) into [master](https://codecov.io/gh/apache/beam/commit/595c7e90c9b956809cb7a0254086e860ebfa7aee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (595c7e9) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #23073 +/- ##
==========================================
- Coverage 73.58% 73.58% -0.01%
==========================================
Files 716 716
Lines 95301 95301
==========================================
- Hits 70127 70125 -2
- Misses 23878 23880 +2
Partials 1296 1296
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.40% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/23073?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...beam/runners/portability/expansion\_service\_main.py](https://codecov.io/gh/apache/beam/pull/23073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9leHBhbnNpb25fc2VydmljZV9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
| [...beam/runners/portability/local\_job\_service\_main.py](https://codecov.io/gh/apache/beam/pull/23073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZV9tYWluLnB5) | `14.43% <ø> (-0.42%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/23073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `93.05% <0.00%> (-0.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/23073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `94.00% <0.00%> (+1.00%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on a diff in pull request #23073: Use cloudpickle for Java Python transforms.
Posted by GitBox <gi...@apache.org>.
ihji commented on code in PR #23073:
URL: https://github.com/apache/beam/pull/23073#discussion_r965374617
##########
sdks/python/apache_beam/runners/portability/expansion_service_main.py:
##########
@@ -39,10 +40,14 @@ def main(argv):
parser.add_argument(
'-p', '--port', type=int, help='port on which to serve the job api')
parser.add_argument('--fully_qualified_name_glob', default=None)
+ parser.add_argument('--default_pickler')
Review Comment:
Any reason not setting cloudpickle as a default pickler in the expansion service? cloudpickle is less compatible or perhaps slower than dill in general cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #23073: Use cloudpickle for Java Python transforms.
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23073:
URL: https://github.com/apache/beam/pull/23073#issuecomment-1240001783
R: @ihji for Python-on-Java GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a diff in pull request #23073: Use cloudpickle for Java Python transforms.
Posted by GitBox <gi...@apache.org>.
robertwb commented on code in PR #23073:
URL: https://github.com/apache/beam/pull/23073#discussion_r965400534
##########
sdks/python/apache_beam/runners/portability/expansion_service_main.py:
##########
@@ -39,10 +40,14 @@ def main(argv):
parser.add_argument(
'-p', '--port', type=int, help='port on which to serve the job api')
parser.add_argument('--fully_qualified_name_glob', default=None)
+ parser.add_argument('--default_pickler')
Review Comment:
We could look at changing the default (for the expansion service, and for Python in general) but I think it's best for now to be explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org