You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "nitheesh-daram (via GitHub)" <gi...@apache.org> on 2023/06/25 11:03:52 UTC
[PR] [ISSUE #4109 ] Code Optimization.[ClientGroupWrapper] (eventmesh)
nitheesh-daram opened a new pull request, #4154:
URL: https://github.com/apache/eventmesh/pull/4154
Fixes #4109
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4109 ] Code Optimization.[ClientGroupWrapper] (eventmesh)
Posted by "nitheesh-daram (via GitHub)" <gi...@apache.org>.
nitheesh-daram commented on PR #4154:
URL: https://github.com/apache/eventmesh/pull/4154#issuecomment-1606723382
> The issue description requires the `fianl` modifier to be added to the attribute. and please check checkstyle.
Made the code review changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4109 ] Code Optimization.[ClientGroupWrapper] (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4154:
URL: https://github.com/apache/eventmesh/pull/4154#issuecomment-1607824541
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4154](https://app.codecov.io/gh/apache/eventmesh/pull/4154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d5f54cb) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/991cbdae829fcc15698654ca2c737575141f5286?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (991cbda) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head d5f54cb differs from pull request most recent head 4a92815. Consider uploading reports for the commit 4a92815 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4154 +/- ##
============================================
- Coverage 16.93% 16.91% -0.03%
Complexity 1410 1410
============================================
Files 588 588
Lines 25739 25753 +14
Branches 2387 2380 -7
============================================
- Hits 4358 4355 -3
- Misses 20946 20964 +18
+ Partials 435 434 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/4154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../protocol/tcp/client/group/ClientGroupWrapper.java](https://app.codecov.io/gh/apache/eventmesh/pull/4154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9ncm91cC9DbGllbnRHcm91cFdyYXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ol/tcp/client/group/ClientSessionGroupMapping.java](https://app.codecov.io/gh/apache/eventmesh/pull/4154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9ncm91cC9DbGllbnRTZXNzaW9uR3JvdXBNYXBwaW5nLmphdmE=) | `0.77% <0.00%> (-0.01%)` | :arrow_down: |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4154/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4109 ] Code Optimization.[ClientGroupWrapper] (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #4154:
URL: https://github.com/apache/eventmesh/pull/4154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org